Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate crab resubmit #8910

Closed
Tracked by #8906
belforte opened this issue Jan 31, 2025 · 4 comments
Closed
Tracked by #8906

validate crab resubmit #8910

belforte opened this issue Jan 31, 2025 · 4 comments

Comments

@belforte
Copy link
Member

No description provided.

@belforte belforte changed the title crab resubmit validate crab resubmit Jan 31, 2025
@belforte
Copy link
Member Author

belforte commented Feb 3, 2025

must make sure that parameter changing in resubmit (time, memory, sites) works

crab resubmit options (from crab resubmit --help)

  • --jobid=id
  • --sitewhitelist=SITEWHITELIST
  • --siteblacklist=SITEBLACKLIST
  • --maxjobruntime=MAXJOBRUNTIME
  • --maxmemory=MAXMEMORY
  • --numcores=NUMCORES
    • looks like it alwasy failed to me ! DagmanResubmitter sets CRAB_RequestedCpus, but the PreJob will use CRAB_RequestedCpus (which is set in DagmanSubmitter) to configure Job.submit.
    • OTOH: do we really want the user to be able to change NUMCORES ??
  • --priority=PRIORITY priority of this task compared to other tasks you own; tasks default to 10
  • --force Force resubmission of successful jobs indicated i --jobids option. Only works if task is not in COMPLETED status

we have plan to deprecate the latter one though dmwm/CRABClient#5273 (comment)

@belforte
Copy link
Member Author

belforte commented Feb 12, 2025

as a start, list of jobs to be resubmitted is correctly propagated, but sitewhitelist is not.
since I need to fix DagmanResubmitter will take care of this as well

@belforte
Copy link
Member Author

belforte commented Feb 12, 2025

above I tested changing the values on individual jobs, i.e. always using --jobid.
Let's do again while acting on the whole task. And avoid numcores which I believe we should deprecate.

  • --sitewhitelist=SITEWHITELIST
  • --siteblacklist=SITEBLACKLIST
  • --maxjobruntime=MAXJOBRUNTIME
  • --maxmemory=MAXMEMORY
  • --priority=PRIORITY

@belforte
Copy link
Member Author

All OK !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant