removed obsolete registerBeforeCommitListener()

Author: dkandalov

src/limitedwip/common/vcs/allow-commit-listener.kt

@@ -4,30 +4,17 @@ import com.intellij.openapi.Disposable
 import com.intellij.openapi.project.Project
 import com.intellij.openapi.util.Disposer
 import com.intellij.openapi.vcs.CheckinProjectPanel
-import com.intellij.openapi.vcs.VcsKey
 import com.intellij.openapi.vcs.changes.Change
 import com.intellij.openapi.vcs.changes.CommitContext
-import com.intellij.openapi.vcs.changes.CommitExecutor
-import com.intellij.openapi.vcs.changes.shelf.ShelveChangesCommitExecutor
 import com.intellij.openapi.vcs.checkin.*
 import com.intellij.openapi.vcs.checkin.CheckinHandler.ReturnResult.CANCEL
 import com.intellij.openapi.vcs.checkin.CheckinHandler.ReturnResult.COMMIT
-import com.intellij.openapi.vcs.impl.CheckinHandlersManager
-import com.intellij.util.containers.MultiMap
 import limitedwip.common.ifNotNull
 import java.util.concurrent.CopyOnWriteArraySet
 
 object AllowCommit: CheckinHandlerFactory() {
     val listeners = CopyOnWriteArraySet<Listener>()
 
-    init {
-        registerBeforeCommitListener(object: Listener {
-            override fun allowCommit(project: Project, changes: List<Change>): Boolean {
-                return listeners.all { it.allowCommit(project, changes) }
-            }
-        })
-    }
-
     override fun createHandler(panel: CheckinProjectPanel, commitContext: CommitContext): CheckinHandler =
         object: CheckinHandler(), CheckinMetaHandler {
             private var result: ReturnResult? = null
@@ -62,58 +49,3 @@ object AllowCommit: CheckinHandlerFactory() {
         fun allowCommit(project: Project, changes: List<Change>): Boolean
     }
 }
-
-/**
- * This function is obsolete because:
- *  - the reflection trick doesn't work anymore since #IC-202.4357.23 or so
- *  - the new commit dialog is not in a separate window,
- *    and to cancel commits CheckinHandlerFactory must be used
- *
- * Not deleting this function for now to maintain compatibility with older IJ versions.
- */
-private fun registerBeforeCommitListener(listener: AllowCommit.Listener): Boolean {
-    // This is a hack caused by limitations of IntelliJ API.
-    //  - cannot use CheckinHandlerFactory because:
-    //		- CheckinHandler is used just before commit (and after displaying commit dialog)
-    // 		- its CheckinHandlerFactory#createSystemReadyHandler() doesn't seem to be called
-    //  - cannot use VcsCheckinHandlerFactory through extension points because need to register
-    //    checkin handler for all VCSs available
-    //  - cannot use CheckinHandlersManager#registerCheckinHandlerFactory() because it doesn't properly
-    //    register VcsCheckinHandlerFactory
-    //
-    // Therefore, using reflection.
-
-    return accessField<MultiMap<VcsKey, VcsCheckinHandlerFactory>>(CheckinHandlersManager.getInstance(), listOf("a", "b", "myVcsMap", "vcsFactories")) { multiMap ->
-        for (key in multiMap.keySet()) {
-            multiMap.putValue(key, DelegatingCheckinHandlerFactory(key as VcsKey, listener))
-        }
-    }
-}
-
-private inline fun <reified T> accessField(anObject: Any, possibleFieldNames: List<String>, f: (T) -> Unit): Boolean {
-    for (field in anObject.javaClass.declaredFields) {
-        if (possibleFieldNames.contains(field.name) && T::class.java.isAssignableFrom(field.type)) {
-            field.isAccessible = true
-            try {
-                f.invoke(field.get(anObject) as T)
-                return true
-            } catch (ignored: Exception) {
-            }
-        }
-    }
-    return false
-}
-
-private class DelegatingCheckinHandlerFactory(key: VcsKey, private val listener: AllowCommit.Listener): VcsCheckinHandlerFactory(key) {
-    override fun createSystemReadyHandler(project: Project): BeforeCheckinDialogHandler {
-        return object: BeforeCheckinDialogHandler() {
-            override fun beforeCommitDialogShown(project: Project, changes: List<Change>, executors: Iterable<CommitExecutor>, showVcsCommit: Boolean): Boolean {
-                return executors.all { it is ShelveChangesCommitExecutor } || listener.allowCommit(project, changes)
-            }
-        }
-    }
-
-    override fun createVcsHandler(panel: CheckinProjectPanel, commitContext: CommitContext): CheckinHandler {
-        return object: CheckinHandler() {}
-    }
-}