Skip to content

Commit 13dc244

Browse files
authored
[bitnami/kafka] Remove hardcoded ports from listeners (bitnami#14251)
Signed-off-by: Fran Mulero <fmulero@vmware.com>
1 parent 9a42e57 commit 13dc244

File tree

3 files changed

+10
-8
lines changed

3 files changed

+10
-8
lines changed

bitnami/kafka/Chart.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -30,4 +30,4 @@ name: kafka
3030
sources:
3131
- https://github.com/bitnami/containers/tree/main/bitnami/kafka
3232
- https://kafka.apache.org/
33-
version: 20.0.2
33+
version: 20.0.3

bitnami/kafka/templates/NOTES.txt

+6-2
Original file line numberDiff line numberDiff line change
@@ -164,13 +164,17 @@ To create a pod that you can use as a Kafka client run the following commands:
164164

165165
PRODUCER:
166166
kafka-console-producer.sh \
167-
{{ if or (include "kafka.client.saslAuthentication" .) (include "kafka.client.tlsEncryption" .) }}--producer.config /tmp/client.properties \{{ end }}
167+
{{- if or (include "kafka.client.saslAuthentication" .) (include "kafka.client.tlsEncryption" .) }}
168+
--producer.config /tmp/client.properties \
169+
{{- end }}
168170
--broker-list {{ join "," $brokerList }} \
169171
--topic test
170172

171173
CONSUMER:
172174
kafka-console-consumer.sh \
173-
{{ if or (include "kafka.client.saslAuthentication" .) (include "kafka.client.tlsEncryption" .) }}--consumer.config /tmp/client.properties \{{ end }}
175+
{{- if or (include "kafka.client.saslAuthentication" .) (include "kafka.client.tlsEncryption" .) }}
176+
--consumer.config /tmp/client.properties \
177+
{{- end }}
174178
--bootstrap-server {{ $fullname }}.{{ $releaseNamespace }}.svc.{{ $clusterDomain }}:{{ .Values.service.ports.client }} \
175179
--topic test \
176180
--from-beginning

bitnami/kafka/templates/statefulset.yaml

+3-5
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22
{{- $fullname := include "common.names.fullname" . }}
33
{{- $releaseNamespace := .Release.Namespace }}
44
{{- $clusterDomain := .Values.clusterDomain }}
5-
{{- $interBrokerPort := .Values.service.ports.internal }}
6-
{{- $clientPort := .Values.service.ports.client }}
75
{{- $interBrokerProtocol := include "kafka.listenerType" (dict "protocol" .Values.auth.interBrokerProtocol) -}}
86
{{- $clientProtocol := include "kafka.listenerType" (dict "protocol" .Values.auth.clientProtocol) -}}
97
{{- $externalClientProtocol := include "kafka.listenerType" (dict "protocol" (include "kafka.externalClientProtocol" . )) -}}
@@ -203,9 +201,9 @@ spec:
203201
{{- if .Values.listeners }}
204202
value: {{ join "," .Values.listeners }}
205203
{{- else if .Values.externalAccess.enabled }}
206-
value: "INTERNAL://:{{ $interBrokerPort }},CLIENT://:9092,EXTERNAL://:9094"
204+
value: "INTERNAL://:{{ .Values.containerPorts.internal }},CLIENT://:{{ .Values.containerPorts.client }},EXTERNAL://:{{ .Values.containerPorts.external }}"
207205
{{- else }}
208-
value: "INTERNAL://:{{ $interBrokerPort }},CLIENT://:9092"
206+
value: "INTERNAL://:{{ .Values.containerPorts.internal }},CLIENT://:{{ .Values.containerPorts.client }}"
209207
{{- end }}
210208
{{- if .Values.externalAccess.enabled }}
211209
{{- if .Values.externalAccess.autoDiscovery.enabled }}
@@ -223,7 +221,7 @@ spec:
223221
{{- if .Values.advertisedListeners }}
224222
value: {{ join "," .Values.advertisedListeners }}
225223
{{- else }}
226-
value: "INTERNAL://$(MY_POD_NAME).{{ $fullname }}-headless.{{ $releaseNamespace }}.svc.{{ $clusterDomain }}:{{ $interBrokerPort }},CLIENT://$(MY_POD_NAME).{{ $fullname }}-headless.{{ $releaseNamespace }}.svc.{{ $clusterDomain }}:{{ $clientPort }}"
224+
value: "INTERNAL://$(MY_POD_NAME).{{ $fullname }}-headless.{{ $releaseNamespace }}.svc.{{ $clusterDomain }}:{{ .Values.service.ports.internal }},CLIENT://$(MY_POD_NAME).{{ $fullname }}-headless.{{ $releaseNamespace }}.svc.{{ $clusterDomain }}:{{ .Values.service.ports.client }}"
227225
{{- end }}
228226
{{- end }}
229227
- name: ALLOW_PLAINTEXT_LISTENER

0 commit comments

Comments
 (0)