Skip to content

Commit 6170403

Browse files
committed
Remove trainling slashes from URLs
1 parent 0adcbe1 commit 6170403

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

pysolr.py

+5-5
Original file line numberDiff line numberDiff line change
@@ -484,11 +484,11 @@ def _select(self, params, handler=None):
484484

485485
if len(params_encoded) < 1024:
486486
# Typical case.
487-
path = "%s/?%s" % (handler, params_encoded)
487+
path = "%s?%s" % (handler, params_encoded)
488488
return self._send_request("get", path)
489489
else:
490490
# Handles very long queries by submitting as a POST.
491-
path = "%s/" % handler
491+
path = "%s" % handler
492492
headers = {
493493
"Content-type": "application/x-www-form-urlencoded; charset=utf-8"
494494
}
@@ -534,7 +534,7 @@ def _update(
534534
path_handler = "select"
535535
query_vars.append("qt=%s" % safe_urlencode(handler, True))
536536

537-
path = "%s/" % path_handler
537+
path = "%s" % path_handler
538538

539539
if commit is None:
540540
commit = self.always_commit
@@ -1261,11 +1261,11 @@ def ping(self, handler="admin/ping", **kwargs):
12611261

12621262
if len(params_encoded) < 1024:
12631263
# Typical case.
1264-
path = "%s/?%s" % (handler, params_encoded)
1264+
path = "%s?%s" % (handler, params_encoded)
12651265
return self._send_request("get", path)
12661266
else:
12671267
# Handles very long queries by submitting as a POST.
1268-
path = "%s/" % handler
1268+
path = "%s" % handler
12691269
headers = {
12701270
"Content-type": "application/x-www-form-urlencoded; charset=utf-8"
12711271
}

tests/test_client.py

+7-7
Original file line numberDiff line numberDiff line change
@@ -566,7 +566,7 @@ def test_search(self):
566566
self.assertEqual(len(results), 3)
567567
# search should default to 'select' handler
568568
args, kwargs = self.solr._send_request.call_args
569-
self.assertTrue(args[1].startswith("select/?"))
569+
self.assertTrue(args[1].startswith("select?"))
570570

571571
results = self.solr.search("example")
572572
self.assertEqual(len(results), 2)
@@ -627,7 +627,7 @@ def test_more_like_this(self):
627627
self.assertEqual(len(results), 0)
628628
# more_like_this should default to 'mlt' handler
629629
args, kwargs = self.solr._send_request.call_args
630-
self.assertTrue(args[1].startswith("mlt/?"))
630+
self.assertTrue(args[1].startswith("mlt?"))
631631

632632
# more_like_this should support custom handlers
633633
with self.assertRaises(SolrError):
@@ -655,7 +655,7 @@ def test_suggest_terms(self):
655655
)
656656
# suggest_terms should default to 'mlt' handler
657657
args, kwargs = self.solr._send_request.call_args
658-
self.assertTrue(args[1].startswith("terms/?"))
658+
self.assertTrue(args[1].startswith("terms?"))
659659

660660
# suggest_terms should support custom handlers
661661
with self.assertRaises(SolrError):
@@ -732,7 +732,7 @@ def test_add(self):
732732
)
733733
# add should default to 'update' handler
734734
args, kwargs = self.solr._send_request.call_args
735-
self.assertTrue(args[1].startswith("update/?"))
735+
self.assertTrue(args[1].startswith("update?"))
736736

737737
self.assertEqual(len(self.solr.search("doc")), 5)
738738
self.assertEqual(len(self.solr.search("example")), 3)
@@ -848,7 +848,7 @@ def test_delete(self):
848848
self.solr.delete(id="doc_1", commit=True)
849849
# delete should default to 'update' handler
850850
args, kwargs = self.solr._send_request.call_args
851-
self.assertTrue(args[1].startswith("update/?"))
851+
self.assertTrue(args[1].startswith("update?"))
852852

853853
self.assertEqual(len(self.solr.search("doc")), 2)
854854
self.assertEqual(len(self.solr.search("type_s:parent")), 2)
@@ -915,7 +915,7 @@ def test_commit(self):
915915
self.solr.commit()
916916
# commit should default to 'update' handler
917917
args, kwargs = self.solr._send_request.call_args
918-
self.assertTrue(args[1].startswith("update/?"))
918+
self.assertTrue(args[1].startswith("update?"))
919919
self.assertEqual(len(self.solr.search("doc")), 4)
920920

921921
def test_can_handles_default_commit_policy(self):
@@ -954,7 +954,7 @@ def test_optimize(self):
954954
self.solr.optimize()
955955
# optimize should default to 'update' handler
956956
args, kwargs = self.solr._send_request.call_args
957-
self.assertTrue(args[1].startswith("update/?"))
957+
self.assertTrue(args[1].startswith("update?"))
958958
self.assertEqual(len(self.solr.search("doc")), 4)
959959

960960
# optimize should support custom handlers

0 commit comments

Comments
 (0)