Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tokio-postgres in diesel_bench #3949

Merged
merged 2 commits into from
Mar 1, 2024

Conversation

sabify
Copy link
Contributor

@sabify sabify commented Feb 28, 2024

No description provided.

Copy link
Member

@weiznich weiznich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain why you would expect different results for this crate than for the postgres crate (which is a thin wrapper over tokio-postgres)?

@weiznich weiznich requested a review from a team February 28, 2024 15:06
@sabify
Copy link
Contributor Author

sabify commented Feb 28, 2024

There's still marginal difference between these two crates performance in benchmark and I thought it would be nice to have that crate in bench feature set.

Please look at the following benchmark result (except for bench_insert that has a bug in this specific run).

Benchmark result: https://github.com/sabify/diesel/actions/runs/8081091336/job/22083538884

@weiznich weiznich added this pull request to the merge queue Mar 1, 2024
Merged via the queue into diesel-rs:master with commit 359da7e Mar 1, 2024
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants