Skip to content

Commit 7692078

Browse files
authored
merge develop
2 parents 3f2daac + e278274 commit 7692078

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

CMakeLists.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ cmake_minimum_required(VERSION 3.24)
22

33
project(
44
dice-template-library
5-
VERSION 1.10.0
5+
VERSION 1.10.1
66
DESCRIPTION
77
"This template library is a collection of template-oriented code that we, the Data Science Group at UPB, found pretty handy. It contains: `switch_cases` (Use runtime values in compile-time context), `integral_template_tuple` (Create a tuple-like structure that instantiates a template for a range of values), `integral_template_variant` (A wrapper type for `std::variant` guarantees to only contain variants of the form `T<IX>` and `for_{types,values,range}` (Compile time for loops for types, values or ranges))."
88
HOMEPAGE_URL "https://dice-research.org/")

include/dice/template-library/channel.hpp

+3-5
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,8 @@
1212
namespace dice::template_library {
1313

1414
/**
15-
* A single producer, single consumer channel/queue
16-
* @note this can technically be used as a multi producer, single consumer queue, but care must be taken
17-
* of when exactly close() is called
18-
* @warning close() must be called once the producing thread is done, otherwise the reading thread will hang indefinitely
15+
* A multi producer, multi consumer channel/queue
16+
* @warning close() must be called once the producing threads are done, otherwise the reading thread will hang indefinitely
1917
*
2018
* @tparam T value type of the channel
2119
*/
@@ -66,7 +64,7 @@ namespace dice::template_library {
6664
std::lock_guard lock{queue_mutex_};
6765
closed_.test_and_set(std::memory_order_release);
6866
}
69-
queue_not_empty_.notify_one(); // notify pop() so that it does not get stuck
67+
queue_not_empty_.notify_all(); // notify pop() so that it does not get stuck
7068
queue_not_full_.notify_all(); // notify emplace()
7169
}
7270

0 commit comments

Comments
 (0)