Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

fix: update ui-core to 4.0 #217

Merged
merged 3 commits into from
Nov 29, 2019
Merged

fix: update ui-core to 4.0 #217

merged 3 commits into from
Nov 29, 2019

Conversation

varl
Copy link
Contributor

@varl varl commented Nov 25, 2019

No description provided.

@varl varl requested a review from a team as a code owner November 25, 2019 17:24
Copy link
Contributor

@Mohammer5 Mohammer5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, tests are passing as well!

@varl
Copy link
Contributor Author

varl commented Nov 27, 2019

Not ready to merge, there is something going on with the profile menu links, only the docs link actually works. Not sure what broke since the <a> is around the MenuItem and should handle the click.

@Mohammer5
Copy link
Contributor

Not ready to merge, there is something going on with the profile menu links, only the docs link actually works. Not sure what broke since the is around the MenuItem and should handle the click.

Which means out tests are not covering everything.. After having figured out the issue, we should add a test for this as well

@varl varl force-pushed the fix/update-ui-core-4 branch from 7016207 to fbf2198 Compare November 28, 2019 16:18
@varl varl force-pushed the fix/update-ui-core-4 branch from 0c1ad2c to 4a3e04b Compare November 29, 2019 09:45
@varl varl merged commit ee2ab20 into master Nov 29, 2019
@varl varl deleted the fix/update-ui-core-4 branch November 29, 2019 09:48
dhis2-bot added a commit that referenced this pull request Nov 29, 2019
## [2.0.4](v2.0.3...v2.0.4) (2019-11-29)

### Bug Fixes

* update ui-core to 4.0 ([#217](#217)) ([ee2ab20](ee2ab20))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 2.0.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants