fix(headerbar): links and app icons

[teug91]

• Fixes HeaderBar: App icons are not loaded correctly #8
• Fixes various header bar links

There is a lot of contextPath prop-drilling. Do you prefer another implementation? Using useContext perhaps?

Also, maybe the locale stuff can be moved into the useEffect?

[amcgee]

Hi @teug91 thank you for this PR! Are you using this version of the HeaderBar with <DataProvider> in a custom DHIS2 apps?

I've been wanting to update the links and icon paths here to support 3rd party domain deployments and non-core apps for a while. I think we will want to use Context rather than prop-drilling, as you say. I'll be extending the API of dhis2/app-runtime shortly with a new hook to access application configuration (especially the baseUrl). We currently have that information available in the DataProvider context but we don't expose the raw context to consumers.

I'll let @varl make the call on whether to accept this as-is and then update it to use context, or to wait for the new context accessor (probably next week).

[teug91]

Yes, I'm using this version along with <DataProvider> in custom apps. Everything seems to be working as expected apart from link and icon paths.

It makes no difference to me if we have to wait for context or if the PR is accepted. Thanks.

[varl]

I'll let @varl make the call on whether to accept this as-is and then update it to use context, or to wait for the new context accessor (probably next week).

@amcgee If it will be available this week, I think we should use the context. If it's going to take longer, merge this.

[varl]

It's been almost a month, so I'm going to go ahead and merge this for now, and we can refactor down the line. This doesn't touch the external component API, so refactoring to Context down the line is a non-breaking change.

Thanks for this, @teug91.

[dhis2-bot]

🎉 This PR is included in version 1.0.7 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[amcgee]

@varl OK sounds good. For reference: This is the app-runtime change to enable context-provided application config dhis2/app-runtime#13