-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cacheable-section): stable references to avoid loops [LIBS-642] #1385
Merged
KaiVandivier
merged 3 commits into
master
from
libs-642-stable-references-for-cacheable-sections
Jul 26, 2024
Merged
fix(cacheable-section): stable references to avoid loops [LIBS-642] #1385
KaiVandivier
merged 3 commits into
master
from
libs-642-stable-references-for-cacheable-sections
Jul 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaminic
approved these changes
Jul 25, 2024
dhis2-bot
added a commit
that referenced
this pull request
Jul 26, 2024
## [3.10.6](v3.10.5...v3.10.6) (2024-07-26) ### Bug Fixes * **cacheable-section:** stable references to avoid loops [LIBS-642] ([#1385](#1385)) ([e3a5fbf](e3a5fbf))
🎉 This PR is included in version 3.10.6 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
KaiVandivier
added a commit
that referenced
this pull request
Nov 25, 2024
…1385) * fix(cacheable-sections): stable references * refactor: avoid needing eslint disable * chore: consistent test names
KaiVandivier
pushed a commit
that referenced
this pull request
Nov 25, 2024
dhis2-bot
added a commit
that referenced
this pull request
Nov 26, 2024
# [3.11.0-alpha.1](v3.10.4-alpha.1...v3.11.0-alpha.1) (2024-11-26) ### Bug Fixes * **cacheable-section:** synchronously flush recording state for UI consistency ([04bc604](04bc604)) * add endpoint to text plain matchers ([#1390](#1390)) ([de8fbec](de8fbec)) * expand FetchErrorDetails type ([#1389](#1389)) ([78ad0b3](78ad0b3)) * handle alert returned async by parentAlertsAdd [LIBS-695] ([#1388](#1388)) ([bba9c23](bba9c23)) * **cacheable-section:** stable references to avoid loops [LIBS-642] ([#1385](#1385)) ([31562e9](31562e9)) * update plugin sizing definition ([#1383](#1383)) ([38c09b9](38c09b9)) * **deps:** remove cli-app-scripts peer dep [LIBS-587] ([#1379](#1379)) ([9e22e88](9e22e88)) * **deps:** update cli-app-scripts for package/types race condition ([dee6795](dee6795)) ### Features * fixed dimensions efficiency ([#1386](#1386)) ([b56ad2d](b56ad2d)) * upgrade app-runtime React version to v18 ([#1387](#1387)) ([0e4a3d5](0e4a3d5))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements LIBS-642
These hooks were implemented unoptimally, admittedly, and functions were getting recreated on each render. This caused issues if they were used as dependencies for
useEffect
hooks, like an infinite loop demoed belowI've updated the hooks to use best practices with
useCallback
anduseMemo
to make stable references and minimize unnecessary rerenders, and I added some automated tests to help verify the stability -- the tests look simplistic, but they were failing before the changes, and actually helped track down which hooks were still unstable in a TDD wayI also tested manually with the PWA example app in the App Platform, with some code that looks like an implementation in analytics plugins:
Demo of loop:
recording-loop-before.mov
After changes:
recording-loop-after.mov