fix: don't silently ignore test failures, fix data reduce bug

dhis2 · Aug 15, 2019 · 95fd038 · 95fd038
1 parent dcb4a70
commit 95fd038
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/package.json b/package.json
@@ -45,16 +45,16 @@
         "typescript": "^3.5.3"
     },
     "scripts": {
-        "install:examples": "loop \"yarn install --force --check-files\" --cwd ./examples",
+        "install:examples": "loop \"yarn install --force --check-files\" --cwd ./examples --exit-on-aggregate-error",
         "build:config": "cd services/config && yarn build",
-        "build:services": "yarn build:config && loop \"yarn build\" --cwd ./services --exclude config",
+        "build:services": "yarn build:config && loop \"yarn build\" --cwd ./services --exclude config --exit-on-error",
         "build:runtime": "cd runtime && yarn build",
         "build": "yarn build:services && yarn build:runtime && yarn install:examples",
-        "test:services": "loop \"yarn test\" --cwd ./services",
+        "test:services": "loop \"yarn test\" --cwd ./services --exit-on-error",
         "test:runtime": "cd runtime && yarn test",
         "test": "yarn test:services && yarn test:runtime",
         "format": "d2-style js apply --all --no-stage",
         "start": "yarn build && cd examples/cra && yarn start"
     },
     "version": "1.4.3"
-}
+}
diff --git a/services/data/src/hooks/useDataQuery.ts b/services/data/src/hooks/useDataQuery.ts
@@ -11,6 +11,7 @@ import { ContextType } from '../types/Context'
 const reduceResponses = (responses: any[], names: string[]) =>
     responses.reduce((out, response, idx) => {
         out[names[idx]] = response
+        return out
     }, {})
 
 const fetchData = (