fix: allow blank cumulative values (DHIS2-18976) #1760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/visualizations/config/adapters/dhis_highcharts/getCumulativeData.js
Outdated
Show resolved
Hide resolved
edoardo
approved these changes
Feb 18, 2025
dhis2-bot
added a commit
that referenced
this pull request
Feb 25, 2025
## [26.12.2](v26.12.1...v26.12.2) (2025-02-25) ### Bug Fixes * allow blank cumulative values (DHIS2-18976) ([#1760](#1760)) ([1fec4a3](1fec4a3))
|
🎉 This PR is included in version 26.12.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements DHIS2-18976
Align with how it works in pivot tables: when accumulating, show blank values as blank, instead of copying the accumulated number.
Cumulative values
Before (219.01 and 287.02 are copied)
After (blank values are blank, accumulation continues after)
Also fixed for two-category charts
Before
After
Hide empty categories now works for cumulative values because they show as blank
Before
After
Hide empty categories in two-category charts
Has never worked. Should be addressed in a separate PR.