Callbase not working on latest 4.8 version

[rotem925]

Hi,
I've upgraded to 4.8.
When setting CallBase=true on new Mock(), and debugging, it seems that the call base does not get called.

Was there any change that could affect this or is there any bug? I didn't see any breaking changes that affect this in the changelog.

Thanks,
Rotem

[stakx]

Hi @rotem925 and thanks for reporting. Could you please provide a short code example that demonstrates the issue you're having?

[rotem925]

Hi @stakx
Thank you for the quick response,
Here is a simple example of the usage:

public class Program
    {
        static void Main(string[] args)
        {
            var mock = new Mock<MyClass>().As<IMyClass>();
            mock.CallBase = true;
            Assert.NotNull(mock.Object.DoSomething()); //this assertion does not pass!!
        }
        public interface IMyClass
        {
            object DoSomething();
        }
        public class MyClass:IMyClass
        {
            public object DoSomething()
            {
                return new object();
            }
        }
    }

[stakx]

@rotem925 - Thanks a lot for the repro code. It looks like this is a regression introduced by 5837c53:

-if (invocation.Method.DeclaringType == typeof(object) || // interface proxy
-	mock.ImplementsInterface(invocation.Method.DeclaringType) && !invocation.Method.LooksLikeEventAttach() && !invocation.Method.LooksLikeEventDetach() && mock.CallBase && !mock.MockedType.GetTypeInfo().IsInterface || // class proxy with explicitly implemented interfaces. The method's declaring type is the interface and the method couldn't be abstract
-	invocation.Method.DeclaringType.GetTypeInfo().IsClass && !invocation.Method.IsAbstract && mock.CallBase // class proxy
-	)
+if (mock.CallBase && !invocation.Method.IsAbstract)

That cryptic multi-line condition had to go for a variety of reasons; one being that it was near incomprehensible. Replacing it with something much simpler was admittedly a bit of a gamble, but I ended up doing it because there was no test failure hinting at any functional change.

Sorry about that. It should be easily fixed, though. Expect a fixed release soon.

[rotem925]

That was fast!
Thank you so much.

[stakx]

@rotem925 - The fix for this is included in Moq 4.8.1 which has just been made available on NuGet.

[rotem925]

@stakx Thanks for the update!
It works great now!