Skip to content

Commit 69f86ae

Browse files
authored
ci: fix split test files ci (#1316)
## Description Closes: #XXXX <!-- Add a description of the changes that this PR introduces and the files that are the most critical to review. --> This PR fixes the CI of splitting test files, currently, it always fails since it requires `go mod tidy` to update `go.mod` before `go list`. https://github.com/desmos-labs/desmos/actions/runs/8479093667/job/23232524696?pr=1309#step:3:172 --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/desmos-labs/desmos/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://docs.cosmos.network/v0.44/building-modules/intro.html) - [ ] included the necessary unit and integration [tests](https://github.com/desmos-labs/desmos/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Chores** - Enhanced the GitHub workflow by incorporating `go mod tidy` before listing packages to ensure a tidy module list. - Introduced a change in CI for fixing split-test-files CI, ensuring backward compatibility. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
1 parent bce3217 commit 69f86ae

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
type: ci
2+
module: none
3+
pull_request: 1316
4+
description: Fix split-test-files ci
5+
backward_compatible: true
6+
date: 2024-03-29T08:53:21.646923062Z

.github/workflows/test.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ jobs:
7070
uses: actions/checkout@v4
7171

7272
- name: Create a file with all the pkgs 📜
73-
run: go list ./... > pkgs.txt
73+
run: go mod tidy && go list ./... > pkgs.txt
7474

7575
- name: Split pkgs into 4 files ✂️
7676
run: split -d -n l/4 pkgs.txt pkgs.txt.part.

0 commit comments

Comments
 (0)