Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMO Validation errors #221

Open
dermeck opened this issue Apr 21, 2024 · 1 comment
Open

AMO Validation errors #221

dermeck opened this issue Apr 21, 2024 · 1 comment

Comments

@dermeck
Copy link
Owner

dermeck commented Apr 21, 2024

There are a few warnings that are related to the build chain (webpack, ts-loader, ... ?)

The Function constructor is eval.
eval can be harmful.
Unsafe assignment to innerHTML

https://addons.mozilla.org/en-US/developers/addon/feeds-sidebar/file/4267989/validation

quick research showed this (not directly related to our build)
https://stackoverflow.com/questions/50358773/webpack-babel-loader-transpiles-code-with-eval
https://stackoverflow.com/questions/48695579/how-to-remove-eval-and-function-constructor-from-webpack-build-to-avoid-csp-issu

(try disabling the source-maps)

Where are those errors listed?
https://addons.mozilla.org/en-US/developers/addon/feeds-sidebar/versions

Check out this as well: https://github.com/mozilla/addons-linter
npx addons-linter test.zip

@dermeck
Copy link
Owner Author

dermeck commented Dec 7, 2024

At least some of the warnings seem to be related to webpack Kocal/vue-web-extension#658 or core-js zloirock/core-js#86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant