Test setting

Author: dereisele

custom_components/simatic/light.py

@@ -28,7 +28,7 @@
 LIGHT_SCHEMA = vol.Schema({
     vol.Required(CONF_NAME): cv.string,
     vol.Required(CONF_STATE_ADDRESS): ADDRESS_SCHEMA,
-    vol.Required(CONF_SET_ADDRESS): ADDRESS_SCHEMA
+    vol.Optional(CONF_SET_ADDRESS): ADDRESS_SCHEMA
 })
 
 PLATFORM_SCHEMA = PLATFORM_SCHEMA.extend({
@@ -64,18 +64,21 @@ def setup_platform(
         state_byte = device[CONF_STATE_ADDRESS][CONF_BYTE]
         state_bit = device[CONF_STATE_ADDRESS][CONF_BIT]
 
-        set_byte = device[CONF_SET_ADDRESS][CONF_BYTE]
-        set_bit = device[CONF_SET_ADDRESS][CONF_BIT]
+        if device.get(CONF_SET_ADDRESS):
+            set_byte = device[CONF_SET_ADDRESS][CONF_BYTE]
+            set_bit = device[CONF_SET_ADDRESS][CONF_BIT]
 
-        lamp = SimaticLight(client, name, (state_byte, state_bit), (set_byte, set_bit))
+            lamp = SimaticLight(client, name, (state_byte, state_bit), (set_byte, set_bit))
+        else:
+            lamp = SimaticLight(client, name, (state_byte, state_bit), None)
         lamps.append(lamp)
 
     add_entities(lamps)
 
 
 class SimaticLight(LightEntity):
 
-    def __init__(self, client: snap7.client.Client, name: str, state_address: tuple[int, int], set_address: tuple[int, int]) -> None:
+    def __init__(self, client: snap7.client.Client, name: str, state_address: tuple[int, int], set_address: tuple[int, int] | None) -> None:
         self._client = client
         self._state_address = state_address
         self._set_address = set_address
@@ -92,19 +95,24 @@ def is_on(self) -> bool | None:
 
     def turn_on(self, **kwargs: Any) -> None:
         _LOGGER.debug(f"turn on lamp {self._name}")
+        self.set_state(1)
 
     def turn_off(self, **kwargs: Any) -> None:
         _LOGGER.debug(f"turn off lamp {self._name}")
+        self.set_state(0)
 
     def set_state(self, value: int):
+        if not self._set_address:
+            _LOGGER.debug(f"Not set configured for lamp {self._name}")
+
         byte, bit = self._set_address
         res = self._client.db_read(10, byte, 1)[0]
         set_v = (value << bit)
         set_byte = bytearray([set_v])
         self._client.db_write(10, byte, set_byte)
 
     def update(self) -> None:
-        _LOGGER.error(f"Updating State for lamp {self._name}")
+        _LOGGER.debug(f"Updating State for lamp {self._name}")
         byte, bit = self._state_address
 
         res = self._client.db_read(10, byte, 1)[0]