Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non localized messages #1750

Closed
thiagoeec opened this issue Aug 5, 2019 · 4 comments
Closed

Non localized messages #1750

thiagoeec opened this issue Aug 5, 2019 · 4 comments
Assignees
Labels
core Issues in the core code (lib/core) docs Documentation changes fix Bug fixes
Milestone

Comments

@thiagoeec
Copy link
Contributor

Expectation: Localized message for this messages:
Fix any of the following / Fix all of the following

Actual: English messages only.

Motivation: All messages to the user should be localized.


axe-core version: 3.3.1

Using Axe bundled with Ace by Daisy (v 1.1.1).

For Tooling issues:
- Node version: 11.4.0 
- Platform:  Windows 10 x64 1903
@WilcoFiers WilcoFiers added the rule metadata Issues in the rule metadata code (lib/rules) label Aug 6, 2019
@WilcoFiers
Copy link
Contributor

We'll take a look. Localisations are maintained partially outside the axe-core main team, so it's not something we guarantee is always up to date.

@WilcoFiers WilcoFiers added fix Bug fixes core Issues in the core code (lib/core) and removed rule metadata Issues in the rule metadata code (lib/rules) labels Aug 30, 2019
@WilcoFiers
Copy link
Contributor

Alright, so my initial assumption was wrong about this. The problem isn't that we don't have localisations of these strings, it's that we're not using them. The reason is that failureMessage is ignored in Audit.prototype.applyLocale:
https://github.com/dequelabs/axe-core/blob/develop/lib/core/base/audit.js#L216

That definitely needs to be fixed.

@jeankaplansky
Copy link
Contributor

jeankaplansky commented Sep 29, 2019

@WilcoFiers, @straker : Should this be a release notes item for axe-core 3.4?

Wilco says yes: 9/29/2019, consider it a "fix"

Entry added 10/14/2019

@padmavemulapati
Copy link

Dev task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Issues in the core code (lib/core) docs Documentation changes fix Bug fixes
Projects
None yet
Development

No branches or pull requests

5 participants