Report violations for every callback of the MutationObserver

(Instead of for every node in every callback of the MutationObserver)

Author: jul-sh

src/AxeObserver.mjs

@@ -31,16 +31,21 @@ export default class AxeObserver {
       )
     }
 
-    this._violationsCallback = violationsCallback
-
     this.observe = this.observe.bind(this)
     this.disconnect = this.disconnect.bind(this)
 
     this._alreadyReportedIncidents = new Set()
     this._mutationObserver = new window.MutationObserver(mutationRecords => {
-      mutationRecords.forEach(mutationRecord => {
-        this._auditNode(mutationRecord.target)
+      const violations = []
+      mutationRecords.forEach(async mutationRecord => {
+        const violationsInCurrentNode = await this._getViolationsForNode(
+          mutationRecord.target
+        )
+        violationsInCurrentNode.forEach(violations.push)
       })
+      if (violations.length > 0) {
+        violationsCallback(violations)
+      }
     })
   }
   observe(targetNode) {
@@ -60,16 +65,16 @@ export default class AxeObserver {
     this._mutationObserver.disconnect()
     this.__alreadyReportedIncidents.clear()
   }
-  async _auditNode(node) {
+  async _getViolationsForNode(node) {
     const response = await sharedAuditQueue.run(async () => {
       // Since audits are scheduled asynchronously, it can happen that
       // the node is no longer connected. We cannot analyze it then.
       return node.isConnected ? axeCore.run(node) : null
     })
 
-    if (!response) return
+    if (!response) return []
 
-    const violationsToReport = response.violations.filter(violation => {
+    return response.violations.filter(violation => {
       const filteredNodes = violation.nodes.filter(node => {
         const key = node.target.toString() + violation.id
 
@@ -87,11 +92,5 @@ export default class AxeObserver {
 
       return filteredNodes.length > 0
     })
-
-    const hasViolationsToReport = violationsToReport.length > 0
-
-    if (hasViolationsToReport) {
-      this._violationsCallback(violationsToReport)
-    }
   }
 }