Why is hyper still required as a dependency (in Errors)?

[trivikr]

I came across this question while going through the deno codebase.

• reqwest was added an an http client in feat: use reqwest as http client #2822 (to replace hyper)
• however, hyper still is used in deno_error.rs

  deno/cli/deno_error.rs

  Lines 219 to 229 in 76e44dd

  	impl GetErrorKind for hyper::Error {
  	fn kind(&self) -> ErrorKind {
  	match self {
  	e if e.is_canceled() => ErrorKind::HttpCanceled,
  	e if e.is_closed() => ErrorKind::HttpClosed,
  	e if e.is_parse() => ErrorKind::HttpParse,
  	e if e.is_user() => ErrorKind::HttpUser,
  	_ => ErrorKind::HttpOther,
  	}
  	}
  	}

Why is this dependency on hyper required?

[bartlomieju]

We use reqwest for our HTTP client which relies on hyper. reqwest::Error does not contain a lot of useful information but we can downcast it to underlying hyper error to get that info. Unfortunately reqwest does not reexport any types from hyper so we need explicit dependency on it. I guess it doesn't matter much because it's already used by reqwest anyway.

This brings another topic which is #2635.

A quick grep through a code base does not yield a single usage of:

• ErroKind.HttpUser
• ErroKind.HttpClosed
• ErroKind.HttpCanceled
• ErroKind.HttpParse

So we should consider removing them and rename ErrorKind.HttpOther to ErroKind.Http.

CC @ry

[bartlomieju]

Fixed in #3662