Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deeply consider adding the cleanup API #2659

Open
Tracked by #2572
lastmjs opened this issue Feb 6, 2025 · 0 comments
Open
Tracked by #2572

deeply consider adding the cleanup API #2659

lastmjs opened this issue Feb 6, 2025 · 0 comments
Milestone

Comments

@lastmjs
Copy link
Member

lastmjs commented Feb 6, 2025

CONSIDER PUTTING THIS IN 1.0 or NEXT

Right now the ic0.call_on_cleanup functionality is exposed indirectly through the Rust CDK. It will apparently invoke destructors for us, and so we use this to clean up the global JS resolve and reject callbacks. But this functionality is not exposed to the end developer...what if they want this functionality?

I'm trying to see if the Rust CDK team is interested in adding the ability for the developer to pass in a cleanup callback of their own during call construction. This would make it a lot easier for us to add this functionality to Azle, if it is desired.

This will not be a breaking change in the future, we should be able to easily add it into the options object for call.

@lastmjs lastmjs mentioned this issue Feb 6, 2025
17 tasks
@lastmjs lastmjs added this to the Release Candidate milestone Feb 6, 2025
@lastmjs lastmjs modified the milestones: Release Candidate, Next Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant