improvement: use clear error if Git Gateway off #1695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tomrutgers Would you mind reviewing the error messages here? |
|
Deploy preview for netlify-cms-www ready! Built with commit 6b10642 |
erquhart
approved these changes
Aug 31, 2018
|
@tech4him1 linting error: 10:34:03 PM: /opt/build/repo/packages/netlify-cms-backend-git-gateway/src/implementation.js
10:34:03 PM: 96:23 error 'APIError' is not defined no-undef
10:34:03 PM: 106:23 error 'APIError' is not defined no-undef
10:34:03 PM: ✖ 2 problems (2 errors, 0 warnings) |
|
Deploy preview for cms-demo ready! Built with commit 6b10642 |
|
Good change @tech4him1. It also occurs to me that we're trusting backends to send valid json instead of testing it, but we can make that improvement outside of this. |
erquhart
approved these changes
Sep 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If Git Gateway is disabled, the current error is very unclear:
Unexpected token < in JSON at position 0. This PR changes to Git Gateway initial settings check code to validate that the request is OK (200 code) and is actually JSON. If not, we output a clear error message.Test plan
A picture of a cute animal (not mandatory but encouraged)