-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: display author of changes in workflow tab #5780
feat: display author of changes in workflow tab #5780
Conversation
fafe278
to
fed1aa7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the follow up @pr0grammm!
This seems to break GitHub when using GraphQL. You can add use the following configuration to reproduce:
backend:
name: github
branch: <branch>
repo: <repo>
use_graphql: true
Also it's missing the Azure DevOps backend.
Finally, should we show the user full name instead of the login handle?
👍
Thanks, I have addressed this, please have a check. GraphQL is supported currently only for GitHub right?
I am quite unfamiliar with this backend. I may be slow to address this.
👍. Since configuring the full name is optional there are chances for it to be empty. We can try to display the full name and if it is empty then we can fallback to the login handle maybe? Also for GitHub I am unable to find the full name returned in the API response. It seems to me only the login is present? |
Yes, it is
Let me see if I can recreate my setup for Azure.
That makes sense
I think so, we might be able to update the GraphQL query to get it, but for the REST API we may need to send an additional request (which is unfortunate) |
@erezrokah wonder why the CI fails? |
We use pre-recorded data to test the different backends. The GraphQL query changes means that we'll need to update the data similar to fb51377. Let me try a find/replace to fix this |
Sure thanks a lot |
447562f
to
bb4bde5
Compare
Hi @erezrokah! For GitLab and BitBucket, it seems that the full name is mandatory after all. So I have skipped checking for the login handle altogether. Hope that's okay. So now only GitHub is left to be handled... |
Made code changes for GitHub backend as part of this commit
61c38bb
to
39118d2
Compare
Done in 39118d2. I hope parallelizing the requests the requests will lower the performance impact of sending an additional one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Awesome! Sorry I was not able to get to this. I think there is also a change needed in the graphql query in GitHub to retrieve the name and not just the login? I'll try to look into that this week. |
Good point! Done in 275ee3b |
feat: display author of changes in workflow tab
Summary
Addresses #5466 : Display author of changes in workflow tab.
Have made code changes to display the post author name below the collection name inside the change card.
Test plan

This PR changes the UI by adding the author name as seen in the below screenshot:
At this time, changes have been made for GitHub backend. Need to propagate the changes for other backends and test for those as well.
Checklist
Please add a
x
inside each checkbox:yarn format
.yarn test
.Cute baby elephant
