some changes

Author: Nicola Strappazzon C

README.md

@@ -1,6 +1,6 @@
 # go-common
 
-Golang library for common projects on DeBeAndo.
+Golang library for common projects on DeBeAndo. When the module is mature or complex, is exported to other repository.
 
 ## Usage
 

aws/rds/logs.go

@@ -15,9 +15,13 @@ type Log struct {
 	Size        int64 // In bytes, file with 75396 bytes is empty.
 }
 
-func (l *Logs) New(input *rds.DescribeDBLogFilesOutput) *Logs {
+func NewLogs() Logs {
+	return Logs{}
+}
+
+func (l *Logs) Decode(input *rds.DescribeDBLogFilesOutput) *Logs {
 	for _, log := range input.DescribeDBLogFiles {
-		*l = append(*l, Log{
+		l.Add(Log{
 			LastWritten: aws.Int64Value(log.LastWritten),
 			FileName:    aws.StringValue(log.LogFileName),
 			Size:        aws.Int64Value(log.Size),
@@ -27,6 +31,10 @@ func (l *Logs) New(input *rds.DescribeDBLogFilesOutput) *Logs {
 	return l
 }
 
+func (l *Logs) Add(in Log) {
+	*l = append(*l, in)
+}
+
 // Len is part of sort.Interface.
 func (l Logs) Len() int {
 	return len(l)

aws/rds/logs_test.go

@@ -0,0 +1,27 @@
+package rds_test
+
+import (
+	"testing"
+
+	"github.com/debeando/go-common/aws/rds"
+
+	"github.com/stretchr/testify/assert"
+)
+
+func TestLogsSort(t *testing.T) {
+	logs := rds.NewLogs()
+	logs.Add(rds.Log{Size: int64(6988063)})
+	logs.Add(rds.Log{Size: int64(27260625)})
+	logs.Add(rds.Log{Size: int64(1398553)})
+	logs.Add(rds.Log{Size: int64(18925915)})
+
+	t.Log(logs.Len())
+
+	// logs.SortBySize()
+
+	for _, log := range logs {
+		t.Log(log.Size)
+	}
+
+	assert.True(t, true)
+}

aws/rds/main.go

@@ -73,7 +73,7 @@ func (r *RDS) Logs(identifier, filename string) (Logs, error) {
 		return Logs{}, err
 	}
 
-	return *logs.New(result), nil
+	return *logs.Decode(result), nil
 }
 
 func (r *RDS) PollLogs(identifier, filename string) (string, error) {
@@ -147,7 +147,7 @@ func (r *RDS) CreateReplica(instance Instance) error {
 		DeletionProtection:              aws.Bool(false),
 		EnableCustomerOwnedIp:           aws.Bool(false),
 		EnableIAMDatabaseAuthentication: aws.Bool(false),
-		EnablePerformanceInsights:       aws.Bool(false),
+		EnablePerformanceInsights:       aws.Bool(true),
 		MultiAZ:                         aws.Bool(false),
 		PubliclyAccessible:              aws.Bool(false),
 		SourceDBInstanceIdentifier:      aws.String(instance.Identifier),

mysql/main.go

@@ -24,9 +24,8 @@ func New(name, dsn string) *Connection {
 			Name: name,
 			DSN:  dsn,
 		}
-		instance[name].Name = name
 	}
-	return instance[name]
+	return Get(name)
 }
 
 func Get(name string) *Connection {

table/rows.go

@@ -22,6 +22,8 @@ func (r *Rows) SortBy(i int) {
 		switch t.Name() {
 		case "int":
 			return int(v1.Int()) < int(v2.Int())
+		case "int64":
+			return int64(v1.Int()) < int64(v2.Int())
 		case "float64":
 			return v1.Float() < v2.Float()
 		case "string":