PHP: use protected fields in order to be extendable (closes snowplow-referer-parser#182)

Author: ilianiv

php/src/Snowplow/RefererParser/Config/ConfigFileReaderTrait.php

@@ -6,12 +6,12 @@
 trait ConfigFileReaderTrait
 {
     /** @var string */
-    private $fileName;
+    protected $fileName;
 
     /** @var array */
-    private $referers = [];
+    protected $referers = [];
 
-    private function init($fileName)
+    protected function init($fileName)
     {
         if (!file_exists($fileName)) {
             throw InvalidArgumentException::fileNotExists($fileName);
@@ -24,7 +24,7 @@ private function init($fileName)
 
     abstract protected function parse($content);
 
-    private function read()
+    protected function read()
     {
         if ($this->referers) {
             return;

php/src/Snowplow/RefererParser/Parser.php

@@ -7,12 +7,12 @@
 class Parser
 {
     /** @var ConfigReaderInterface */
-    private $configReader;
+    protected $configReader;
 
     /**
      * @var string[]
      */
-    private $internalHosts = [];
+    protected $internalHosts = [];
 
     public function __construct(ConfigReaderInterface $configReader = null, array $internalHosts = [])
     {
@@ -59,7 +59,7 @@ public function parse($refererUrl, $pageUrl = null)
         return Referer::createKnown($referer['medium'], $referer['source'], $searchTerm);
     }
 
-    private static function parseUrl($url)
+    protected static function parseUrl($url)
     {
         if ($url === null) {
             return null;
@@ -73,7 +73,7 @@ private static function parseUrl($url)
         return array_merge(['query' => null, 'path' => '/'], $parts);
     }
 
-    private function lookup($host, $path)
+    protected function lookup($host, $path)
     {
         $referer = $this->lookupPath($host, $path);
 
@@ -84,7 +84,7 @@ private function lookup($host, $path)
         return $this->lookupHost($host);
     }
 
-    private function lookupPath($host, $path)
+    protected function lookupPath($host, $path)
     {
         $referer = $this->lookupHost($host, $path);
 
@@ -101,7 +101,7 @@ private function lookupPath($host, $path)
         return $this->lookupPath($host, $path);
     }
 
-    private function lookupHost($host, $path = null)
+    protected function lookupHost($host, $path = null)
     {
         do {
             $referer = $this->configReader->lookup($host . $path);
@@ -111,7 +111,7 @@ private function lookupHost($host, $path = null)
         return $referer;
     }
 
-    private static function createDefaultConfigReader()
+    protected static function createDefaultConfigReader()
     {
         return new JsonConfigReader(__DIR__ . '/../../../data/referers.json');
     }

php/src/Snowplow/RefererParser/Referer.php

@@ -4,15 +4,15 @@
 class Referer
 {
     /** @var string */
-    private $medium;
+    protected $medium;
 
     /** @var string */
-    private $source;
+    protected $source;
 
     /** @var string|null */
-    private $searchTerm;
+    protected $searchTerm;
 
-    private function __construct()
+    protected function __construct()
     {}
 
     public static function createKnown($medium, $source, $searchTerm = null)