Skip to content

Commit d8cf447

Browse files
Fixing an issue where the mutually exclusive range test doesn't work … (#430)
* Fixing an issue where the mutually exclusive range test doesn't work with store failures with a multi-column concatenated partition by clause. As per: #423 * Bumping dbt version to take into account CircleCI already being upgrade to dbt 1.0b as per Joel Labes * Further tweak to version number checks to try to fix CircleCI * Update pull_request_template.md (#438) * Update pull_request_template.md * Update .github/pull_request_template.md * Add 0.8.0 changelog block * Add changelog for mutually excl ranges change
1 parent cd4c5e2 commit d8cf447

File tree

3 files changed

+12
-2
lines changed

3 files changed

+12
-2
lines changed

.github/pull_request_template.md

+4-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,10 @@ Describe your changes, and why you're making them.
1414
- [ ] Postgres
1515
- [ ] Redshift
1616
- [ ] Snowflake
17-
- [ ] I have "dispatched" any new macro(s) so non-core adapters can also use them (e.g. [the `star()` source](https://github.com/fishtown-analytics/dbt-utils/blob/master/macros/sql/star.sql))
17+
- [ ] I followed guidelines to ensure that my changes will work on "non-core" adapters by:
18+
- [ ] dispatching any new macro(s) so non-core adapters can also use them (e.g. [the `star()` source](https://github.com/fishtown-analytics/dbt-utils/blob/master/macros/sql/star.sql))
19+
- [ ] using the `limit_zero()` macro in place of the literal string: `limit 0`
20+
- [ ] using `dbt_utils.type_*` macros instead of explicit datatypes (e.g. `dbt_utils.type_timestamp()` instead of `TIMESTAMP`
1821
- [ ] I have updated the README.md (if applicable)
1922
- [ ] I have added tests & descriptions to my models (and macros if applicable)
2023
- [ ] I have added an entry to CHANGELOG.md

CHANGELOG.md

+7
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,10 @@
1+
# dbt-utils v0.8.0
2+
## 🚨 Breaking changes
3+
- The partition column in the `mutually_exclusive_ranges` test is now always called `partition_by_col`. This enables compatibility with `--store-failures` when multiple columns are concatenated together. If you have models built on top of the failures table, update them to reflect the new column name. ([#423](https://github.com/dbt-labs/dbt-utils/issues/423), [#430](https://github.com/dbt-labs/dbt-utils/pull/430))
4+
5+
## Contributors:
6+
- [codigo-ergo-sum](https://github.com/codigo-ergo-sum) (#430)
7+
18
# dbt-utils v0.7.4b1
29
This is a compatibility release in preparation for `dbt-core` v1.0.0 (🎉). When dbt-core 1.0.0 hits release candidate status, we will release the final version of 0.7.4
310

macros/schema_tests/mutually_exclusive_ranges.sql

+1-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ with window_functions as (
3535

3636
select
3737
{% if partition_by %}
38-
{{ partition_by }},
38+
{{ partition_by }} as partition_by_col,
3939
{% endif %}
4040
{{ lower_bound_column }} as lower_bound,
4141
{{ upper_bound_column }} as upper_bound,

0 commit comments

Comments
 (0)