add test data and test for haversine

too many curly brackets

make params be strings

pass strings

remove round to see if this was the problem

let's try casting

round the output field instead

add commas

cast the macro result directly

rename expected to output

is it a rounding error

swap the units

what is going on...

throw a log to see what we get

remove curlies

try computing in a CTE first'

add comma

I'm sleeping...

fixup! I'm sleeping...

rename in CTE

dont quote?

fix macro and separate unit in two tests

fix yaml indent

fix indentation in schema yaml

alias the field

clean up

fixup! clean up

make the macro log stuff

remove logging in test macro

remove the select star

Author: bastienboutonnet

integration_tests/data/geo/data_haversine_km.csv

@@ -0,0 +1,2 @@
+lat_1,lon_1,lat_2,lon_2,output
+48.864716,2.349014,52.379189,4.899431,430

integration_tests/data/geo/data_haversine_mi.csv

@@ -0,0 +1,2 @@
+lat_1,lon_1,lat_2,lon_2,output
+48.864716,2.349014,52.379189,4.899431,267

integration_tests/dbt_project.yml

@@ -52,4 +52,4 @@ seeds:
 
     sql:
       data_events_20180103:
-        +schema: events
+        +schema: events

integration_tests/macros/tests.sql

@@ -1,6 +1,5 @@
 
 {% macro test_assert_equal(model, actual, expected) %}
-
 select count(*) from {{ model }} where {{ actual }} != {{ expected }}
 
 {% endmacro %}

integration_tests/models/geo/schema.yml

@@ -0,0 +1,13 @@
+version: 2
+
+models:
+  - name: test_haversine_distance_km
+    tests:
+      - assert_equal:
+          actual: actual
+          expected: expected
+  - name: test_haversine_distance_mi
+    tests:
+      - assert_equal:
+          actual: actual
+          expected: expected

integration_tests/models/geo/test_haversine_distance_km.sql

@@ -0,0 +1,23 @@
+with data as (
+    select * from {{ ref('data_haversine_km') }}
+), 
+final as (
+    select
+        output as expected,
+        cast(
+            {{
+                dbt_utils.haversine_distance(
+                    lat1='lat_1', 
+                    lon1='lon_1',
+                    lat2='lat_2',
+                    lon2='lon_2',
+                    unit='km'
+                    )
+            }} as numeric
+        ) as actual
+    from data
+)
+select
+    expected,
+    round(actual,0) as actual
+from final

integration_tests/models/geo/test_haversine_distance_mi.sql

@@ -0,0 +1,23 @@
+with data as (
+    select * from {{ ref('data_haversine_mi') }}
+), 
+final as (
+    select
+        output as expected,
+        cast(
+            {{
+                dbt_utils.haversine_distance(
+                    lat1='lat_1', 
+                    lon1='lon_1',
+                    lat2='lat_2',
+                    lon2='lon_2',
+                    unit='mi'
+                    )
+            }} as numeric
+        ) as actual
+    from data
+)
+select
+    expected,
+    round(actual,0) as actual
+from final

macros/geo/haversine_distance.sql

@@ -10,12 +10,13 @@ The arguments should be float type.
     {{ return(adapter.dispatch('haversine_distance', packages = dbt_utils._get_utils_namespaces())(lat1,lon1,lat2,lon2,unit)) }}
 {% endmacro %}
 
-{% macro default__haversine_distance(lat1,lon1,lat2,lon2,unit='km') -%}
+{% macro default__haversine_distance(lat1,lon1,lat2,lon2,unit) -%}
+{{log(unit, info=true)}}
 {# vanilla macro is in miles #}
-    {% set conversion = '' %}
+    {% set conversion_rate = '' %}
 {% if unit == 'km' %}
 {# we multiply miles result to get it in kms #}
-    {% set conversion = '* 1.60934' %}
+    {% set conversion_rate = '* 1.60934' %}
 {% endif %}
 
     2 * 3961 * asin(sqrt((sin(radians(({{lat2}} - {{lat1}}) / 2))) ^ 2 +