Experiment with adding functional tests

Author: jtcohen6

run_functional_test.sh

@@ -10,4 +10,4 @@ if [[ ! -f $VENV ]]; then
 fi
 
 . $VENV
-python3 -m pytest tests/functional --profile $1
+python3 -m pytest tests/functional -n4 --profile $1

tests/functional/data_type/base_data_type_macro.py

@@ -0,0 +1,48 @@
+import os
+import pytest
+from dbt.tests.util import run_dbt, check_relations_equal, get_relation_columns
+
+class BaseDataTypeMacro:
+    @pytest.fixture(scope="class")
+    def packages(self):
+        return {"packages": [{"local": os.getcwd()}]}
+
+    def is_legacy(self):
+        return False
+
+    def test_check_types_assert_match(self, project):
+        run_dbt(['deps'])
+        run_dbt(['build'])
+        
+        # check contents equal
+        check_relations_equal(project.adapter, ["expected", "actual"])
+        
+        # check types equal
+        expected_cols = get_relation_columns(project.adapter, "expected")
+        actual_cols = get_relation_columns(project.adapter, "actual")
+        print(f"Expected: {expected_cols}")
+        print(f"Actual: {actual_cols}")
+        
+        
+        if not self.is_legacy():
+            assert expected_cols == actual_cols, f"Type difference detected: {expected_cols} vs. {actual_cols}"
+        # we need to be a little more lenient when mapping between 'legacy' and 'new' types that are equivalent
+        # e.g. 'character varying' and 'text'
+        elif expected_cols == actual_cols:
+            # cool, no need for jank
+            pass
+        else:
+            # this is pretty janky
+            for i in range(0, len(expected_cols)):
+                expected = project.adapter.Column(*expected_cols[i])
+                actual = project.adapter.Column(*actual_cols[i])
+                print(f"Subtle type difference detected: {expected.data_type} vs. {actual.data_type}")
+                if any((
+                    expected.is_string() and actual.is_string(),
+                    expected.is_float() and actual.is_float(),
+                    expected.is_integer() and actual.is_integer(),
+                    expected.is_numeric() and actual.is_numeric(),
+                )):
+                    pytest.xfail()
+                else:
+                    pytest.fail()

tests/functional/data_type/test_type_bigint.py

@@ -0,0 +1,42 @@
+import os
+import pytest
+from tests.functional.data_type.base_data_type_macro import BaseDataTypeMacro
+
+models__expected_sql = """
+select 9223372036854775800 as bigint_col
+""".lstrip()
+
+models__actual_sql = """
+select cast('9223372036854775800' as {{ dbt_utils.type_bigint() }}) as bigint_col
+"""
+
+# previous dbt_utils code, replaced in this PR
+macros__legacy_sql = """
+{% macro default__type_bigint() %}
+    bigint
+{% endmacro %}
+
+{% macro bigquery__type_bigint() %}
+    int64
+{% endmacro %}
+"""
+
+
+class TestTypeBigInt(BaseDataTypeMacro):
+    @pytest.fixture(scope="class")
+    def models(self):
+        return {
+            "expected.sql": models__expected_sql,
+            "actual.sql": models__actual_sql
+        }
+
+
+class TestTypeBigIntLegacy(TestTypeBigInt):
+    @pytest.fixture(scope="class")
+    def macros(self):
+        return {
+            "legacy.sql": macros__legacy_sql
+        }
+
+    def is_legacy(self):
+        return True

tests/functional/data_type/test_type_float.py

@@ -0,0 +1,47 @@
+import os
+import pytest
+from tests.functional.data_type.base_data_type_macro import BaseDataTypeMacro
+
+seeds__expected_csv = """float_col
+1.2345
+""".lstrip()
+
+models__actual_sql = """
+select cast('1.2345' as {{ dbt_utils.type_float() }}) as float_col
+"""
+
+# previous dbt_utils code, replaced in this PR
+macros__legacy_sql = """
+{% macro default__type_float() %}
+    float
+{% endmacro %}
+
+{% macro bigquery__type_float() %}
+    float64
+{% endmacro %}
+"""
+
+
+class TestTypeFloat(BaseDataTypeMacro):
+    @pytest.fixture(scope="class")
+    def seeds(self):
+        return {
+            "expected.csv": seeds__expected_csv
+        }
+    
+    @pytest.fixture(scope="class")
+    def models(self):
+        return {
+            "actual.sql": models__actual_sql
+        }
+
+
+class TestTypeFloatLegacy(TestTypeFloat):
+    @pytest.fixture(scope="class")
+    def macros(self):
+        return {
+            "legacy.sql": macros__legacy_sql
+        }
+
+    def is_legacy(self):
+        return True

tests/functional/data_type/test_type_int.py

@@ -0,0 +1,47 @@
+import os
+import pytest
+from tests.functional.data_type.base_data_type_macro import BaseDataTypeMacro
+
+seeds__expected_csv = """int_col
+12345678
+""".lstrip()
+
+models__actual_sql = """
+select cast('12345678' as {{ dbt_utils.type_int() }}) as int_col
+"""
+
+# previous dbt_utils code, replaced in this PR
+macros__legacy_sql = """
+{% macro default__type_int() %}
+    int
+{% endmacro %}
+
+{% macro bigquery__type_int() %}
+    int64
+{% endmacro %}
+"""
+
+
+class TestTypeFloat(BaseDataTypeMacro):
+    @pytest.fixture(scope="class")
+    def seeds(self):
+        return {
+            "expected.csv": seeds__expected_csv
+        }
+    
+    @pytest.fixture(scope="class")
+    def models(self):
+        return {
+            "actual.sql": models__actual_sql
+        }
+
+
+class TestTypeFloatLegacy(TestTypeFloat):
+    @pytest.fixture(scope="class")
+    def macros(self):
+        return {
+            "legacy.sql": macros__legacy_sql
+        }
+
+    def is_legacy(self):
+        return True

tests/functional/data_type/test_type_numeric.py

@@ -0,0 +1,58 @@
+import os
+import pytest
+from tests.functional.data_type.base_data_type_macro import BaseDataTypeMacro
+
+seeds__expected_csv = """numeric_col
+1.2345
+""".lstrip()
+
+# need to explicitly cast this to avoid it being a double/float
+seeds__expected_yml = """
+version: 2
+seeds:
+  - name: expected
+    config:
+      column_types:
+        numeric_col: numeric(5,4)
+"""
+
+models__actual_sql = """
+select cast('1.2345' as {{ dbt_utils.type_numeric() }}) as numeric_col
+"""
+
+# previous dbt_utils code, replaced in this PR
+macros__legacy_sql = """
+{% macro default__type_numeric() %}
+    numeric(28, 6)
+{% endmacro %}
+
+{% macro bigquery__type_numeric() %}
+    numeric
+{% endmacro %}
+"""
+
+
+class TestTypeNumeric(BaseDataTypeMacro):
+    @pytest.fixture(scope="class")
+    def seeds(self):
+        return {
+            "expected.csv": seeds__expected_csv,
+            "expected.yml": seeds__expected_yml
+        }
+    
+    @pytest.fixture(scope="class")
+    def models(self):
+        return {
+            "actual.sql": models__actual_sql
+        }
+
+
+class TestTypeNumericLegacy(TestTypeNumeric):
+    @pytest.fixture(scope="class")
+    def macros(self):
+        return {
+            "legacy.sql": macros__legacy_sql
+        }
+
+    def is_legacy(self):
+        return True

tests/functional/data_type/test_type_string.py

@@ -0,0 +1,55 @@
+import os
+import pytest
+from tests.functional.data_type.base_data_type_macro import BaseDataTypeMacro
+
+seeds__expected_csv = """string_col
+"Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum."
+""".lstrip()
+
+models__actual_sql = """
+select cast('Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.' as {{ dbt_utils.type_string() }}) as string_col
+"""
+
+# previous dbt_utils code, replaced in this PR
+macros__legacy_sql = """
+{% macro default__type_string() %}
+    string
+{% endmacro %}
+
+{%- macro redshift__type_string() -%}
+    varchar
+{%- endmacro -%}
+
+{% macro postgres__type_string() %}
+    varchar
+{% endmacro %}
+
+{% macro snowflake__type_string() %}
+    varchar
+{% endmacro %}
+"""
+
+
+class TestTypeString(BaseDataTypeMacro):
+    @pytest.fixture(scope="class")
+    def seeds(self):
+        return {
+            "expected.csv": seeds__expected_csv
+        }
+    
+    @pytest.fixture(scope="class")
+    def models(self):
+        return {
+            "actual.sql": models__actual_sql
+        }
+
+
+class TestTypeStringLegacy(TestTypeString):
+    @pytest.fixture(scope="class")
+    def macros(self):
+        return {
+            "legacy.sql": macros__legacy_sql
+        }
+
+    def is_legacy(self):
+        return True

tests/functional/data_type/test_type_timestamp.py

@@ -0,0 +1,52 @@
+import os
+import pytest
+from tests.functional.data_type.base_data_type_macro import BaseDataTypeMacro
+
+seeds__expected_csv = """timestamp_col
+2021-01-01 01:01:01
+""".lstrip()
+
+models__actual_sql = """
+select cast('2021-01-01 01:01:01' as {{ dbt_utils.type_timestamp() }}) as timestamp_col
+"""
+
+# previous dbt_utils code, replaced in this PR
+macros__legacy_sql = """
+{% macro default__type_timestamp() %}
+    timestamp
+{% endmacro %}
+
+{% macro postgres__type_timestamp() %}
+    timestamp without time zone
+{% endmacro %}
+
+{% macro snowflake__type_timestamp() %}
+    timestamp_ntz
+{% endmacro %}
+"""
+
+
+class TestTypeTimestamp(BaseDataTypeMacro):
+    @pytest.fixture(scope="class")
+    def seeds(self):
+        return {
+            "expected.csv": seeds__expected_csv
+        }
+    
+    @pytest.fixture(scope="class")
+    def models(self):
+        return {
+            "actual.sql": models__actual_sql
+        }
+
+
+class TestTypeTimestampLegacy(TestTypeTimestamp):
+    @pytest.fixture(scope="class")
+    def macros(self):
+        return {
+            "legacy.sql": macros__legacy_sql
+        }
+
+    def is_legacy(self):
+        return True
+