Add upper_bound_column to order by (#660)

* Add upper_bound_column to order by

* Update CHANGELOG

* Update integration test

* Remove overlap between partitions

Co-authored-by: Joel Labes <joel.labes@dbtlabs.com>

Author: sfc-gh-ancoleman

CHANGELOG.md

@@ -15,10 +15,12 @@
 
 ## Fixes
 - Better handling of whitespaces in the star macro ([#651](https://github.com/dbt-labs/dbt-utils/pull/651))
+- Fix to correct behavior in `mutually_exclusive_ranges` test in certain situations when `zero_length_range_allowed: true` and multiple ranges in a partition have the same value for `lower_bound_column`. ([[#659](https://github.com/dbt-labs/dbt-utils/issues/659)], [#660](https://github.com/dbt-labs/dbt-utils/pull/660))
 
 ## Contributors:
 - [@christineberger](https://github.com/christineberger) (#624)
 - [@courentin](https://github.com/courentin) (#651)
+- [@sfc-gh-ancoleman](https://github.com/sfc-gh-ancoleman) (#660)
 
 # dbt-utils v0.8.6
 

integration_tests/data/schema_tests/data_test_mutually_exclusive_ranges_with_gaps_zero_length.csv

@@ -1,7 +1,8 @@
 subscription_id,valid_from,valid_to
 3,2020-05-06,2020-05-07
+3,2020-05-08,2020-05-10
 3,2020-05-08,2020-05-08
-3,2020-05-09,2020-05-10
+3,2020-05-12,2020-05-15
 4,2020-06-06,2020-06-07
 4,2020-06-08,2020-06-08
-4,2020-06-09,2020-06-10
+4,2020-06-09,2020-06-10

macros/generic_tests/mutually_exclusive_ranges.sql

@@ -42,12 +42,12 @@ with window_functions as (
 
         lead({{ lower_bound_column }}) over (
             {{ partition_clause }}
-            order by {{ lower_bound_column }}
+            order by {{ lower_bound_column }}, {{ upper_bound_column }}
         ) as next_lower_bound,
 
         row_number() over (
             {{ partition_clause }}
-            order by {{ lower_bound_column }} desc
+            order by {{ lower_bound_column }} desc, {{ upper_bound_column }} desc
         ) = 1 as is_last_record
 
     from {{ model }}