Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pool library instead of epgsql_pool or emysql #12

Closed
manuel-rubio opened this issue Nov 14, 2017 · 5 comments
Closed

Use pool library instead of epgsql_pool or emysql #12

manuel-rubio opened this issue Nov 14, 2017 · 5 comments

Comments

@manuel-rubio
Copy link
Contributor

Instead of use specific pools for each driver, the idea is use poolboy or wpool instead to use only one pool library for all of the SQL possibilities.

@manuel-rubio manuel-rubio changed the title User pool library instead of epgsql_pool or emysql Use pool library instead of epgsql_pool or emysql Feb 23, 2018
@tsloughter
Copy link

I'd suggest against poolboy. It just isn't a good fit for database connection pooling. You should checkout https://github.com/SpaceTime-IoT/pgo/blob/master/src/pgo_pool.erl which i stole from elixir-ecto/db_connection#108 :)

@manuel-rubio
Copy link
Contributor Author

@tsloughter I could suggest to create a dbi_pgo project if you want. My idea is provide different providers to the coders can choose but keeping dbi as core base.

@manuel-rubio
Copy link
Contributor Author

In https://github.com/dbi-beam/dbi_pgsql and https://github.com/dbi-beam/dbi_mysql is implemented poolboy as pool for connections so, it's done.

@tsloughter
Copy link

Ah ok, didn't realize it was already done.

@manuel-rubio
Copy link
Contributor Author

@tsloughter I did it today :-P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants