Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bot doesn't check if a Refinery is on top of Geyser in BuildingPlacer #7

Open
ghost opened this issue Aug 11, 2017 · 4 comments
Open
Assignees
Labels

Comments

@ghost
Copy link

ghost commented Aug 11, 2017

Seems like the bot can't execute this strategy because he can't build reapers:
"3Rax_Reapers" : { "Race" : "Terran", "OpeningBuildOrder" : ["SCV", "SupplyDepot", "SCV", "SCV", "SCV", "Refinery", "SCV", "Barracks", "SCV", "Refinery", "SCV", "Barracks", "SCV", "Barracks", "SCV", "SupplyDepot", "SCV", "SupplyDepot", "Reaper", "Reaper", "Reaper", "Reaper", "Reaper", "Reaper", "Reaper", "Reaper", "Reaper", "Reaper", "Reaper", "Reaper", "Reaper", "Reaper", "Reaper", "Reaper", "Reaper", "Reaper", "Reaper", "Reaper"] },
And sometimes he builds extra refinery, sometimes not, also not clear why.

@davechurchill
Copy link
Owner

davechurchill commented Aug 11, 2017

I've fixed this in code but havent recompiled the binary release yet

The reason it may build an extra refinery is because you've specified 2 in the build-order, but I haven't correctly implemented expansion bases yet, so it may be buggy. Will update it as soon as I can

@ghost
Copy link
Author

ghost commented Aug 11, 2017

I'm sorry, I said that not clear enough: as "extra refinery" I mean a second refinery in the main base, not something fancy like a refinery in the expansion.
So in my turn it would be better to say: "and sometimes he builds second refinery, sometimes not. Not clear why".

@davechurchill
Copy link
Owner

I believe it's because I don't currently check to see if there's a refinery on the geyser I've chosen. So the order in which I check them is through the iterator which may just be randomly ordered. I will fix this shortly, thanks!

@davechurchill davechurchill self-assigned this Aug 11, 2017
@davechurchill davechurchill changed the title 3Rax Reapers strategy not working Bot doesn't check if a Refinery is on top of Geyser in BuildingPlacer Aug 13, 2017
@ArtaSeify
Copy link
Contributor

This bug has been fixed with #82.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants