Use upload-artifact v4 because v3 is deprecated and the action cannot be run

Author: milanmajchrak

.github/workflows/build.yml

@@ -12,7 +12,7 @@ on:
       - dtq-dev
       - customer/*
   pull_request:
-  workflow_dispatch:
+  workflow_dispatch: 
 
 permissions:
   contents: read  #  to fetch code (actions/checkout)
@@ -82,13 +82,44 @@ jobs:
       # (This artifact is downloadable at the bottom of any job's summary page)
       - name: Upload Results of ${{ matrix.type }} to Artifact
         if: ${{ failure() }}
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: ${{ matrix.type }} results
           path: ${{ matrix.resultsdir }}
 
-      # https://github.com/codecov/codecov-action
-      - name: Upload coverage to Codecov.io
-        uses: codecov/codecov-action@v3
+      # Upload code coverage report to artifact, so that it can be shared with the 'codecov' job (see below)
+      - name: Upload code coverage report to Artifact
+        uses: actions/upload-artifact@v4
         with:
-          token: ${{ secrets.CODECOV_TOKEN }} # not required for public repos
+          name: ${{ matrix.type }} coverage report
+          path: 'dspace/target/site/jacoco-aggregate/jacoco.xml'
+          retention-days: 14
+
+  # # Codecov upload is a separate job in order to allow us to restart this separate from the entire build/test
+  # # job above. This is necessary because Codecov uploads seem to randomly fail at times.
+  # # See https://community.codecov.com/t/upload-issues-unable-to-locate-build-via-github-actions-api/3954
+  # codecov:
+  #   # Must run after 'tests' job above
+  #   needs: tests
+  #   runs-on: ubuntu-latest
+  #   steps:
+  #     - name: Checkout
+  #       uses: actions/checkout@v3
+
+  #     # Download artifacts from previous 'tests' job
+  #     - name: Download coverage artifacts
+  #       uses: actions/download-artifact@v3
+
+  #     # Now attempt upload to Codecov using its action.
+  #     # NOTE: We use a retry action to retry the Codecov upload if it fails the first time.
+  #     #
+  #     # Retry action: https://github.com/marketplace/actions/retry-action
+  #     # Codecov action: https://github.com/codecov/codecov-action
+  #     - name: Upload coverage to Codecov.io
+  #       uses: Wandalen/wretry.action@v1.0.36
+  #       with:
+  #         action: codecov/codecov-action@v3
+  #         # Try upload 5 times max
+  #         attempt_limit: 5
+  #         # Run again in 30 seconds
+  #         attempt_delay: 30000