Elevate next-status and iter_gitstatus()
#679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An added file is and stays added only, even if it has unstaged modifications on top. Ping datalad#637
Decided to reuse the existing `modification_types` qualifiers. It is a bit weird that the type enum is called `GitContainerModificationType`. It is primarily targeting submodules -- so this makes some sense. But it does not make sense to install another enum for the same purpose. It should probably be just `GitModificationType`.
The previous setup used red/green (like git-status) to communicate the nature of a change. But that was poorly aligned. See datalad#640 This change does NOT align with Git's behavior. Instead, it acknowledges even more that DataLad does not work with Git's staging of content in the index. Color coding is now purely about the nature of the change (add, delete, mod, untracked), and not its status with respect to the index. Closes datalad#640
The previous implementation assumed that no submodule items need to be produced, because individual modification reports from within the submodules would be sufficient. However, this missed all cases with new submodule commits, but no other changes. This change adjusts the implementation and tests to produce and verify modification reports for such cases. Closes datalad#645
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
next-statusstate reporting too simplistic #637next-statusresult rendering could be better aligned with Git's #640next-status -r monoreporting of a submodule with new commits #645Screenshot on the default output of
next-status -r mono, arrows highly the changes.