Fix git ls-file parsing in iter_gitworktree()
#421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the regular expression that analyses git output in such a way, that it only consumes a single tab character before the file name. That change makes it work with file names that start with a tab-character.
christian-monch
force-pushed
the
fix-git-lsfile-parsing
branch
2 times, most recently
from
a6822fd to
938e29c
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #421 +/- ##
==========================================
- Coverage 92.06% 92.01% -0.05%
==========================================
Files 122 122
Lines 9020 9033 +13
==========================================
+ Hits 8304 8312 +8
- Misses 716 721 +5
☔ View full report in Codecov by Sentry. |
christian-monch
force-pushed
the
fix-git-lsfile-parsing
branch
2 times, most recently
from
baa144e to
fc2fcd5
Compare
mih
reviewed
Jun 16, 2023
This commit adds a regression test to ensure that file-names starting with a tab-character are properly parsed from the output of `git ls-files`. The test instantiates PurePosixPath-instances to check against names in the output of `iter_gitworktree`, because `iter_gitworktree` explicitly creates PurePosixPath-instances in the function `_lsfiles_line2props`.
christian-monch
force-pushed
the
fix-git-lsfile-parsing
branch
from
fc2fcd5 to
d1e9efe
Compare
|
Crippled-FS conditions fixed now by using: |
christian-monch
force-pushed
the
fix-git-lsfile-parsing
branch
from
87c3c4e to
bec45ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the regular expression that is used during execution of
iter_gitworktree()in order to parse the output ofgit ls-tree.The current version ensures that only one tab-character is considered to separate the file info from the file name. That ensures that file names that start with tab-characters are properly handled (the previous version, would consider all tab-characters, including the tab-characters belonging to the name, as file-info/file-name separator).
The PR includes a regression test that verifies correct handling of file names starting with tab-characters