Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create-sibling-github produces None(token ✓) credential #97

Closed
mih opened this issue Aug 18, 2022 · 0 comments · Fixed by #98
Closed

create-sibling-github produces None(token ✓) credential #97

mih opened this issue Aug 18, 2022 · 0 comments · Fixed by #98

Comments

@mih
Copy link
Member

mih commented Aug 18, 2022

Found while looking into datalad/datalad#6945
mih added a commit that referenced this issue Aug 18, 2022
@mih
Make sure a token secret always has a non-None name
5c7de69 
Otherwise a freshly entered token would have a proper realm configured
(and work smoothly), but be prone to naming conflicts.

Fixes #97
@mih mih mentioned this issue Aug 18, 2022
Merged
mih added a commit that referenced this issue Aug 18, 2022
@mih
Make sure a token secret always has a non-None name
a3d511b 
Otherwise a freshly entered token would have a proper realm configured
(and work smoothly), but be prone to naming conflicts.

Fixes #97
@mih mih closed this as completed in #98 Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make sure a token secret always has a non-None name datalad/datalad-next
1 participant
@mih