plugin does not install if helm is helm 3 but run from helm 2

[schollii]

The install-binary.sh script uses the helm home command which only exists in helm 3. Interestingly, if either helm 2 XOR helm 3 are installed on my system, the plugin installs fine. However if both versions of helm are on my system, and helm is actually helm 3, and helm 2 has some other name, then the plugin no longer installs for helm 2:

• helm version shows helm 3
• helm plugin install https://github.com/databus23/helm-diff works
• helm2 version shows helm 2
• helm2 plugin install https://github.com/databus23/helm-diff fails with error message that home is not a recognized command

At first unclear what this is about, but inspection of source code indicates the error happens because install-binary.sh calls helm home, which in the above scenario actually calls helm 3, which does not support home command (I'm guessing that helm 3's plugin install does not use that script otherwise it would fail too).

Is there a reason that $(helm home) cannot be replaced by $HELM_HOME?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[schollii]

I'd like to keep this open. I'll submit a PR and see what happens.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[schollii]

bump

[mumoshu]

@schollii I think #270 fixed this issue. Would you mind confirming?

[schollii]

It looks like it might but I have to try it to be sure. I will post result soon.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[schollii]

Looks like #270 fixes this indeed