Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release --disable-openapi-validation #220

Closed
iameli opened this issue Jun 23, 2020 · 4 comments
Closed

release --disable-openapi-validation #220

iameli opened this issue Jun 23, 2020 · 4 comments

Comments

@iameli
Copy link

iameli commented Jun 23, 2020

EDIT: Whoops, this already exists. Could we get a 3.1.2 release that includes the fix? Thanks!

Love the plugin, thanks so much for writing it!

I'm running against a cluster with the ServiceTopology feature gate enabled. Helm doesn't know about it, so it fails OpenAPI validation.

> helm diff upgrade -f .build/staging-livepeer.rkv.values.yaml staging-livepeer ./charts/livepeer
Error: Failed to render chart: exit status 1: coalesce.go:199: warning: destination for annotations is a table. Ignoring non-table value []
coalesce.go:199: warning: destination for annotations is a table. Ignoring non-table value []
coalesce.go:199: warning: destination for annotations is a table. Ignoring non-table value []
Error: unable to build kubernetes objects from release manifest: error validating "": error validating data: ValidationError(Service.spec): unknown field "topologyKey" in io.k8s.api.core.v1.ServiceSpec

Error: plugin "diff" exited with error

With the regular helm upgrade command, I can bypass validation and still upgrade my cluster using helm upgrade --disable-openapi-validation. It would be nice if I could use helm-diff in the same way.

@iameli
Copy link
Author

iameli commented Jun 23, 2020

Oh, hilarious, this is literally the tip of master right now. My bad! 26d61fa

@iameli iameli closed this as completed Jun 23, 2020
@iameli iameli changed the title support --disable-openapi-validation release --disable-openapi-validation Jun 23, 2020
@iameli iameli reopened this Jun 23, 2020
@iameli
Copy link
Author

iameli commented Jun 23, 2020

(Will close when this releases)

@iameli
Copy link
Author

iameli commented Jun 28, 2020

(In the meantime I threw it up on a fork so helm plugin install https://github.com/livepeer/helm-diff --version master works)

@mumoshu
Copy link
Collaborator

mumoshu commented Jul 31, 2020

@iameli Finally this has been released in v3.1.2. Thanks for patience!

JFYI, I had to use --disable-validation added in #228 for "installing" prometheus-operator because it needs to "ignore" validation errors due to missing(unregistered) API versions.

For your original issue, --disable-openapi-validation should indeed be enough.

@mumoshu mumoshu closed this as completed Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants