Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: return 404 for missing files (INFRA-735) #465

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

siers
Copy link
Contributor

@siers siers commented Jan 23, 2025

Technically, the underlying function checks for file accessibility, but an internal server error would be inappropriate even then.

Technically, the underlying function checks for file accessibility, but
an internal server error would be inappropriate even then.
Copy link

linear bot commented Jan 23, 2025

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 23.2%. Comparing base (4231f00) to head (a8ca8fc).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/SipiHttpServer.cpp 0.0% 0 Missing and 1 partial ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
src/SipiHttpServer.cpp 22.2% <0.0%> (+0.7%) ⬆️

... and 5 files with indirect coverage changes

@siers siers requested a review from seakayone January 24, 2025 09:46
@siers siers merged commit f54356f into main Jan 24, 2025
3 of 4 checks passed
@siers siers deleted the feat/not-found-for-missing branch January 24, 2025 13:58
@SamuelBoerlin
Copy link

Thanks for the fix @siers ! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants