Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: tilted images are imported without tilting (DEV-1666) #374

Merged
merged 45 commits into from
Jan 18, 2023
Merged

feat: tilted images are imported without tilting (DEV-1666) #374

merged 45 commits into from
Jan 18, 2023

Conversation

subotic
Copy link
Contributor

@subotic subotic commented Dec 11, 2022 •
edited
Loading

  • remove PDF support
  • DEV-1666: adjusts SIPI, so that in the future, tilted images are imported without tilting

lrosenth and others added 11 commits February 26, 2022 01:17
@lrosenth
Removed PDF support which made a lot of troubles...
477cc69
@lrosenth
Adapted tests to new mimtype detector
77d2fa2
@subotic
Merge branch 'main' into wip/remove-pdf
6ea8b92
@subotic
build: bump sipi base version
224bf06
@subotic
fix merge conflicts
0b401e6
@lrosenth
compilation under OS X
873f20b
@subotic
build: improve local development environment
dc2cd26
@subotic
Merge remote-tracking branch 'origin/wip/remove-pdf' into remove-pdf
97f41cf
@subotic
Merge branch 'main' into remove-pdf
8da3352
@subotic
Merge branch 'remove-pdf' of github.com:dasch-swiss/sipi into remove-pdf
5547a03
@subotic
Squashed commit of the following:
c8b85ce 
commit 6b49303
Author: Marcin Procyk <marcin.procyk@dasch.swiss>
Date:   Fri Sep 9 15:31:13 2022 +0200

    fix syntax

commit d66a359
Author: Marcin Procyk <marcin.procyk@dasch.swiss>
Date:   Thu Sep 8 10:51:01 2022 +0200

    add support for ODD and RNG file types
@subotic subotic mentioned this pull request Dec 11, 2022
Closed
subotic and others added 18 commits December 11, 2022 19:24
@subotic
bump sipi-base
bd26755
@subotic
add docker development environment
fdef11c
@subotic
bump ubuntu, clang, and optimize local dev env
3430f82
@subotic
bump sipi-base and add missing dependency
bf88e63
@subotic
change make target for running tests to the same folder clion uses
bd26f77
@subotic
fix remote sipi env
610f328
@subotic
test: log more for integration tests
2801a44
@subotic
bump github actions and python
ac23164
@subotic
bump github actions and python
34738d5
@subotic
test: add logging in case of failure for integration tests
b76720e
@subotic
remove extra logging in integration tests
1c4a37e
@lrosenth
Orientation fix
f4c77d9
@lrosenth
Merge branch 'remove-pdf' of github.com:dasch-swiss/sipi into remove-pdf
7c50b6e 
# Conflicts:
#	src/sipi.cpp
#	test/e2e/conftest.py
#	test/e2e/test_02_server.py
@lrosenth
Apple Silicon support
711f40b
@subotic
bump sipi-base
b90578c
@subotic
Merge branch 'remove-pdf' of github.com:dasch-swiss/sipi into remove-pdf
7f8f050
@subotic
bump sipi-base and kakadu for CI
ab5e82e
@subotic
fix building under arm-linux
1d2de02
@subotic subotic changed the title Many improvements feat: tilted images are imported without tilting (DEV-31) Jan 17, 2023
@subotic subotic merged commit 8f65c6c into main Jan 18, 2023
@subotic subotic deleted the remove-pdf branch January 18, 2023 17:04
@linear
Copy link

linear bot commented Jan 27, 2023

DEV-31 DSP-APP displays images distorted or in mosaics due to bad SIPI behaviour

When images have an EXIF orientation of Rotate 270 CW or Rotate 90 CW, SIPI doesn’t calculate the height/width correctly when converting the image to JP2. The original images are valid, but the JP2 are invalid. As a result, DSP-APP displays these images distorted or in mosaics.

This problem must be resolved in 2 subtasks:

  • Lukas Rosenthaler adjusts SIPI, so that in the future, tilted images are imported correctly
  • Johannes Nussbaum writes a Shell script that the Infra team will execute once on the affected servers, to correct the already existing data

The details of this problem are more amply described in the two subtasks.

For historical interest:
https://dasch.myjetbrains.com/youtrack/issue/DSP-1885

See screenshots for more examples.

@subotic subotic changed the title feat: tilted images are imported without tilting (DEV-31) feat: tilted images are imported without tilting (DEV-1666) Jan 27, 2023
@linear
Copy link

linear bot commented Jan 27, 2023

DEV-1666 Add conversion of non top-left zero point to top-left zero point image during conversion to JP2

@daschbot daschbot mentioned this pull request Apr 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@subotic @lrosenth