Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support guard features in mapping token protocol v2 #114

Closed
hackfisher opened this issue Dec 20, 2021 · 2 comments · Fixed by #124
Closed

Support guard features in mapping token protocol v2 #114

hackfisher opened this issue Dec 20, 2021 · 2 comments · Fixed by #124

Comments

@hackfisher
Copy link
Contributor

darwinia-network/darwinia-common#755

Related #101

Guard is supposed to in the application layer.

e.g. When inbound lane call unlockFromRemote, it should store the balance instead of transfer to dest instantly, and there is a guard selected by Wormhole DAO who is keeping check and provide signatures to the dest user to withdraw the received token.

There is no audit attacking from guard, since Wormhole DAO can replace the guard if required.

@hackfisher
Copy link
Contributor Author

This guard is removed in truth layer, but can be used as implementation reference for this issue and token layer:

#117

@xiaoch05
Copy link
Contributor

related #124

@xiaoch05 xiaoch05 linked a pull request Jan 15, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants