Skip to content
This repository has been archived by the owner on Mar 13, 2023. It is now read-only.

Backing and Issuing renaming #627

Closed
hackfisher opened this issue May 18, 2021 · 4 comments · Fixed by #782
Closed

Backing and Issuing renaming #627

hackfisher opened this issue May 18, 2021 · 4 comments · Fixed by #782
Assignees
@aurexav

Comments

@hackfisher
Copy link
Contributor

hackfisher commented May 18, 2021 •
edited
Loading

Outdated:

  • frame/bridge/ethereum/backing darwinia-ethereum-backing -> darwinia-substrate2ethereum-backing
  • frame/bridge/ethereum/issuing darwinia-ethereum-issuing -> darwinia-ethereum2substrate-issuing
  • frame/bridge/tron/backing/Cargo.toml darwinia-tron-backing -> darwinia-substrate2tron-backing

frame/bridge/crab/backing will later be replaced by substrate2substrate-backing.
frame/bridge/crab/issuing will later be replaced by substrate2substrate-issuing.

Pallet name in runtime should use this format too, such as Darwinia2EthereumBacking, Ethereum2DarwiniaIssuing Darwinia2CrabBacking etc.
@aurexav aurexav self-assigned this Jul 12, 2021
@hackfisher hackfisher mentioned this issue Aug 19, 2021
Closed
23 tasks
@hackfisher
Copy link
Contributor Author

hackfisher commented Aug 19, 2021 •
edited
Loading

From the perspective of mapping token protocol, there are two chains backing chain and issuing chain, backing chain is where mapping token's origin native token located, and issuing chain is where the mapping token located.

These backing and issuing pallet are for the uses of token layer and wormhole app, thus should be split from bridge folder, and move to a new wormhole folder.

Following is the suggested & simplified folder structure and naming:

  • wormhole
    • backing
      • to-ethereum-backing
      • to-substrate-backing
      • to-tron-backing
    • issuing
      • from-ethereum-issuing
      • from-substrate-issuing
      • from-bsc-issuing

@xiaoch05 xiaoch05 mentioned this issue Aug 25, 2021
Closed
17 tasks
@aurexav aurexav linked a pull request Aug 30, 2021 that will close this issue
New Bridge Name Spec #782
Merged
@aurexav
Copy link
Member

aurexav commented Aug 30, 2021 •
edited
Loading 

* frame/bridge/ethereum/backing  darwinia-ethereum-backing -> darwinia-substrate2ethereum-backing

* frame/bridge/ethereum/issuing  darwinia-ethereum-issuing -> darwinia-ethereum2substrate-issuing

* frame/bridge/tron/backing/Cargo.toml darwinia-tron-backing -> darwinia-substrate2tron-backing

frame/bridge/crab/backing will later be replaced by substrate2substrate-backing.
frame/bridge/crab/issuing will later be replaced by substrate2substrate-issuing.

Pallet name in runtime should use this format too, such as Darwinia2EthereumBacking, Ethereum2DarwiniaIssuing Darwinia2CrabBacking etc.

According to the desc.

Darwinia2CrabBacking: substrate2substrate_backing::{Pallet, Storage, Config<T>} = 34,

This looks weird.

Should we make the substrate-backing pallet supporting multi-instances?

@hackfisher
Copy link
Contributor Author

Should we make the substrate-backing pallet supporting multi-instances?

Maybe not now, just do restructure and rename this time.

@hackfisher
Copy link
Contributor Author

This looks weird.

This quote is outdated, please use the latest comment:

Following is the suggested & simplified folder structure and naming:

  • wormhole
    • backing
      • to-ethereum-backing
      • to-substrate-backing
      • to-tron-backing
    • issuing
      • from-ethereum-issuing
      • from-substrate-issuing
      • from-bsc-issuing

@aurexav aurexav closed this as completed Aug 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aurexav aurexav

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

New Bridge Name Spec darwinia-network/darwinia-common
2 participants
@hackfisher @aurexav