Merge branch 'main' into feat/package-config-language-version-relational

Author: parlough

pkgs/package_config/CHANGELOG.md

@@ -3,6 +3,9 @@
 - Add relational operators to `LanguageVersion` with extension methods
   exported under `LanguageVersionRelationalOperators`.
 
+- Include correct parameter names in errors when validating
+  the `major` and `minor` versions in the `LanguageVersion.new` constructor.
+
 ## 2.1.1
 
 - Require Dart 3.4

pkgs/package_config/lib/src/package_config.dart

@@ -301,9 +301,15 @@ abstract class Package {
 abstract class LanguageVersion implements Comparable<LanguageVersion> {
   /// The maximal value allowed by [major] and [minor] values;
   static const int maxValue = 0x7FFFFFFF;
+
+  /// Constructs a [LanguageVersion] with the specified
+  /// [major] and [minor] version numbers.
+  ///
+  /// Both [major] and [minor] must be greater than or equal to 0
+  /// and less than or equal to [maxValue].
   factory LanguageVersion(int major, int minor) {
     RangeError.checkValueInInterval(major, 0, maxValue, 'major');
-    RangeError.checkValueInInterval(minor, 0, maxValue, 'major');
+    RangeError.checkValueInInterval(minor, 0, maxValue, 'minor');
     return SimpleLanguageVersion(major, minor, null);
   }
 

pkgs/package_config/test/package_config_impl_test.dart

@@ -20,11 +20,23 @@ void main() {
     });
 
     test('negative major', () {
-      expect(() => LanguageVersion(-1, 1), throwsArgumentError);
+      expect(
+          () => LanguageVersion(-1, 1),
+          throwsA(isA<RangeError>().having(
+            (e) => e.name,
+            'message',
+            contains('major'),
+          )));
     });
 
     test('negative minor', () {
-      expect(() => LanguageVersion(1, -1), throwsArgumentError);
+      expect(
+          () => LanguageVersion(1, -1),
+          throwsA(isA<RangeError>().having(
+            (e) => e.name,
+            'message',
+            contains('minor'),
+          )));
     });
 
     test('minimal parse', () {