Skip to content

Commit 80406c7

Browse files
committed
Enable and fix unnecessary_ignore lint
1 parent 2ccfc5c commit 80406c7

File tree

4 files changed

+4
-5
lines changed

4 files changed

+4
-5
lines changed

analysis_options.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -19,3 +19,4 @@ analyzer:
1919
linter:
2020
rules:
2121
- avoid_private_typedef_functions
22+
- unnecessary_ignore

pkgs/test/lib/src/runner/browser/compilers/compiler_support.dart

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import 'package:shelf/shelf.dart' as shelf;
1111
import 'package:test_api/backend.dart' show StackTraceMapper, SuitePlatform;
1212
import 'package:test_core/src/runner/configuration.dart'; // ignore: implementation_imports
1313
import 'package:test_core/src/runner/suite.dart'; // ignore: implementation_imports
14-
import 'package:web_socket_channel/web_socket_channel.dart'; // ignore: implementation_imports
14+
import 'package:web_socket_channel/web_socket_channel.dart';
1515

1616
/// The shared interface for all compiler support libraries.
1717
abstract class CompilerSupport {

pkgs/test_core/lib/src/runner/reporter/json.dart

+1-3
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,7 @@ import 'dart:io' show pid;
99
import 'package:collection/collection.dart';
1010
import 'package:path/path.dart' as p;
1111
import 'package:stack_trace/stack_trace.dart';
12-
import 'package:test_api/hooks.dart' // ignore: implementation_imports
13-
show
14-
TestFailure;
12+
import 'package:test_api/hooks.dart' show TestFailure;
1513
import 'package:test_api/src/backend/compiler.dart'; // ignore: implementation_imports
1614
import 'package:test_api/src/backend/group.dart'; // ignore: implementation_imports
1715
import 'package:test_api/src/backend/live_test.dart'; // ignore: implementation_imports

pkgs/test_core/lib/src/runner/vm/environment.dart

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import 'dart:async';
77
import 'package:async/async.dart';
88
import 'package:vm_service/vm_service.dart';
99

10-
import '../environment.dart'; // ignore: implementation_imports
10+
import '../environment.dart';
1111

1212
/// The environment in which VM tests are loaded.
1313
class VMEnvironment implements Environment {

0 commit comments

Comments
 (0)