[CP] [vm/ffi] Fix constant Finalizables

[dcharkes]

Commit(s) to merge

d3ea8bf

Target

stable

Issue Description

class A implements Finalizable {}

void b([A? a]) {}

void main() {
  b();
}

crashes the compiler in dart compile exe.

What is the fix

The VM relied on only seeing expression types emitted by the transformer implementing finalizable in the CFE. However, further transforms could change that expression, in this instance to a constant. The fix is that the VM just accepts all expressions types.

Why cherry-pick

At least one user is running into this in production (cc @blaugold).

• Compiler crash with optional Finalizable parameter #49402 (comment)

Risk

low

Issue link(s)

• Compiler crash with optional Finalizable parameter #49402

Extra Info

No response

[itsjustkevin]

@vsmenon @mraleph @a-siva This is a small change that seems to be low risk. What are your thoughts on this CP? A decision today would allow this cp to make it into the next release.

[mraleph]

I support CP

[vsmenon]

lgtm

[a-siva]

lgtm

[itsjustkevin]

Approving the cherry pick based on consensus. Thank you everyone!

[whesse]

This was picked into stable 2.17.6