Skip to content

Commit d0a3daf

Browse files
bderocommit-bot@chromium.org
authored and
commit-bot@chromium.org
committed
Revert "[vm/concurrency] Enable isolate groups by-default in all modes"
This reverts commit 57de39d. Reason for revert: Breakage in flutter engine roll -- see: flutter/flutter#89406 Original change's description: > [vm/concurrency] Enable isolate groups by-default in all modes > > Various VM embedders have already explicitly opted into it > AOT mode for a long time. > > Now we turn it on by default, also because we'd like to collect > feedback from the field on this - in good time before the next > stable branch will be released. > > All of our isolate related tests have already > > // VMOptions=--enable-isolate-groups ... > // VMOptions=--no-enable-isolate-groups ... > > So they will continue to exercise the tests in both modes. > > Issue #36097 > > TEST=Existing test suite. > > Change-Id: I1d031e8a5f2173b48eb32c53b08daccda75dc51d > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/208649 > Reviewed-by: Slava Egorov <vegorov@google.com> > Reviewed-by: Siva Annamalai <asiva@google.com> > Reviewed-by: Alexander Aprelev <aam@google.com> > Commit-Queue: Martin Kustermann <kustermann@google.com> TBR=vegorov@google.com,kustermann@google.com,aam@google.com,asiva@google.com Change-Id: I4f20f3a998508b2465e5c16b64b363419da62775 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/212345 Auto-Submit: Brandon DeRosier <bdero@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com> Commit-Queue: Martin Kustermann <kustermann@google.com>
1 parent 00f20a0 commit d0a3daf

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

runtime/tests/vm/dart/isolates/dart_api_create_lightweight_isolate_test.dart

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
// BSD-style license that can be found in the LICENSE file.
44

55
// SharedObjects=ffi_test_functions
6-
// VMOptions=--no-enable-isolate-groups
6+
// VMOptions=
77
// VMOptions=--enable-isolate-groups --disable-heap-verification
88

99
import 'dart:async';

runtime/tests/vm/dart_2/isolates/dart_api_create_lightweight_isolate_test.dart

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
// @dart = 2.9
66

77
// SharedObjects=ffi_test_functions
8-
// VMOptions=--no-enable-isolate-groups
8+
// VMOptions=
99
// VMOptions=--enable-isolate-groups --disable-heap-verification
1010

1111
import 'dart:async';

runtime/vm/flag_list.h

+2-1
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,8 @@ constexpr bool FLAG_support_il_printer = false;
196196
P(retain_code_objects, bool, true, \
197197
"Serialize all code objects even if not otherwise " \
198198
"needed in the precompiled runtime.") \
199-
P(enable_isolate_groups, bool, true, "Enable isolate group support.") \
199+
P(enable_isolate_groups, bool, false, \
200+
"Enable isolate group support in AOT.") \
200201
P(show_invisible_frames, bool, false, \
201202
"Show invisible frames in stack traces.") \
202203
D(trace_cha, bool, false, "Trace CHA operations") \

0 commit comments

Comments
 (0)