enable depend_on_referenced_packages

this is under consideration for core lint inclusion: https://github.com/dart-lang/lints/issues/42

(also undoubtably nice to get the early warning.)

Change-Id: I3ea204444f48d3b4bde3ff65b4ce85a2cf2a7b11
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/202301
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>

Author: pq

pkg/analysis_server/analysis_options.yaml

@@ -17,6 +17,7 @@ linter:
   rules:
     - await_only_futures
     - avoid_single_cascade_in_expression_statements
+    - depend_on_referenced_packages
     - empty_statements
     - iterable_contains_unrelated_type
     - list_remove_unrelated_type

pkg/analysis_server_client/analysis_options.yaml

@@ -5,6 +5,7 @@ analyzer:
 linter:
   rules:
     - await_only_futures
+    - depend_on_referenced_packages
     - empty_statements
     - unnecessary_brace_in_string_interps
     #

pkg/analyzer/analysis_options.yaml

@@ -30,6 +30,7 @@ linter:
     - avoid_dynamic_calls
     - avoid_unused_constructor_parameters
     - await_only_futures
+    - depend_on_referenced_packages
     - empty_statements
     - iterable_contains_unrelated_type
     - list_remove_unrelated_type

pkg/analyzer_cli/analysis_options.yaml

@@ -11,6 +11,7 @@ analyzer:
 linter:
   rules:
     avoid_unused_constructor_parameters: true
+    depend_on_referenced_packages: true
     directives_ordering: true
 
     # We import heavily from package:analyzer/src.

pkg/analyzer_plugin/analysis_options.yaml

@@ -4,6 +4,7 @@ analyzer:
 linter:
   rules:
     - await_only_futures
+    - depend_on_referenced_packages
     - empty_statements
     - unnecessary_brace_in_string_interps
     #

pkg/dartdev/analysis_options.yaml

@@ -13,6 +13,7 @@ analyzer:
 linter:
   rules:
     - always_declare_return_types
+    - depend_on_referenced_packages
     - directives_ordering
     - overridden_fields
     - prefer_single_quotes