Add flutter support (#155)

* Add flutter support

* Add changelog

* Rev version

* Fix small bug in health

Author: mosuem

pkgs/base_repo

@@ -0,0 +1 @@
+Subproject commit 65817bf10a4e5c45a99299aa4ae92a0993bf9847

pkgs/firehose/CHANGELOG.md

@@ -1,3 +1,6 @@
+## 0.3.26
+
+- Add support for Flutter package auto-publishing, fixing [#154](https://github.com/dart-lang/ecosystem/issues/154).
 ## 0.3.25
 
 - Switch to pub.dev API in `package:firehose`.

pkgs/firehose/lib/firehose.dart

@@ -115,7 +115,7 @@ Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automati
       print('Validating $package:${package.name}');
 
       print('pubspec:');
-      var pubspecVersion = package.pubspec.version;
+      var pubspecVersion = package.pubspec.version?.toString();
       if (pubspecVersion == null) {
         var result = Result.fail(
           package,
@@ -146,16 +146,15 @@ Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automati
         var result = Result.info(package, 'already published at pub.dev');
         print(result);
         results.addResult(result);
-      } else if (package.pubspec.isPreRelease) {
+      } else if (package.pubspec.version!.isPreRelease) {
         var result = Result.info(
           package,
           'pre-release version (no publish necessary)',
         );
         print(result);
         results.addResult(result);
       } else {
-        var code = await runCommand('dart',
-            args: ['pub', 'publish', '--dry-run'], cwd: package.directory);
+        final code = await _runPublish(package, dryRun: true, force: false);
 
         final ignoreWarnings = github.prLabels.contains(_ignoreWarningsLabel);
 
@@ -245,7 +244,7 @@ Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automati
     print('');
 
     print('pubspec:');
-    var pubspecVersion = package.pubspec.version;
+    var pubspecVersion = package.pubspec.version?.toString();
     print('  version: $pubspecVersion');
 
     print('changelog:');
@@ -267,13 +266,35 @@ Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automati
     await runCommand('dart', args: ['pub', 'get'], cwd: package.directory);
     print('');
 
-    var result = await runCommand('dart',
-        args: ['pub', 'publish', '--force'], cwd: package.directory);
+    var result = await _runPublish(package, dryRun: false, force: true);
     if (result != 0) {
       exitCode = result;
     }
     return result == 0;
   }
+
+  Future<int> _runPublish(
+    Package package, {
+    required bool dryRun,
+    required bool force,
+  }) async {
+    String command;
+    if (package.pubspec.dependencies.containsKey('flutter')) {
+      command = 'flutter';
+    } else {
+      command = 'dart';
+    }
+    return await runCommand(
+      command,
+      args: [
+        'pub',
+        'publish',
+        if (dryRun) '--dry-run',
+        if (force) '--force',
+      ],
+      cwd: package.directory,
+    );
+  }
 }
 
 class VerificationResults {

pkgs/firehose/lib/src/health/coverage.dart

@@ -31,6 +31,7 @@ class Coverage {
 
     var filesOfInterest = files
         .where((file) => path.extension(file.filename) == '.dart')
+        .where((file) => file.status != FileStatus.removed)
         .where((file) => isInSomePackage(packages, file.relativePath))
         .where((file) => isNotATest(packages, file.relativePath))
         .toList();

pkgs/firehose/lib/src/pubspec.dart

@@ -6,10 +6,10 @@ import 'dart:io';
 
 import 'package:firehose/src/changelog.dart';
 import 'package:path/path.dart' as path;
+import 'package:pubspec_parse/pubspec_parse.dart';
 import 'package:yaml/yaml.dart' as yaml;
 
 import 'github.dart';
-import 'pubspec.dart';
 
 class Repository {
   final Directory baseDirectory;
@@ -90,13 +90,16 @@ class Package {
   late final Changelog changelog;
 
   Package(this.directory, this.repository) {
-    pubspec = Pubspec(directory);
-    changelog = Changelog(File(path.join(directory.path, 'CHANGELOG.md')));
+    pubspec = Pubspec.parse(_getPackageFile('pubspec.yaml').readAsStringSync());
+    changelog = Changelog(_getPackageFile('CHANGELOG.md'));
   }
 
+  File _getPackageFile(String fileName) =>
+      File(path.join(directory.path, fileName));
+
   String get name => pubspec.name;
 
-  String? get version => pubspec.version;
+  String? get version => pubspec.version?.toString();
 
   @override
   String toString() {

pkgs/firehose/lib/src/repo.dart

@@ -1,6 +1,6 @@
 name: firehose
 description: A tool to automate publishing of Pub packages from GitHub actions.
-version: 0.3.25
+version: 0.3.26
 repository: https://github.com/dart-lang/ecosystem/tree/main/pkgs/firehose
 
 environment:
@@ -16,6 +16,7 @@ dependencies:
   http: ^0.13.0
   path: ^1.8.0
   pub_semver: ^2.1.0
+  pubspec_parse: ^1.2.3
   yaml: ^3.1.0
 
 dev_dependencies: