Merge pull request #1359 from Samuel-B-D/get-url-parameter-test

Fix `getUrlParameter`'s handling of fragment response

Author: damienbod

projects/angular-auth-oidc-client/src/lib/utils/url/url.service.spec.ts

@@ -118,6 +118,20 @@ describe('UrlService Tests', () => {
       expect(code).toBe('thisisacode');
       expect(state).toBe('0000.1234.000');
     });
+
+    it('gets correct params when response_mode=fragment', () => {
+      // Test url taken from an example in the RFC: https://datatracker.ietf.org/doc/html/rfc6749#section-4.2.2
+      const urlToCheck = 'http://example.com/cb#access_token=2YotnFZFEjr1zCsicMWpAA&state=xyz&token_type=example&expires_in=3600';
+      const accessToken = service.getUrlParameter(urlToCheck, 'access_token');
+      const state = service.getUrlParameter(urlToCheck, 'state');
+      const tokenType = service.getUrlParameter(urlToCheck, 'token_type');
+      const expiresIn = service.getUrlParameter(urlToCheck, 'expires_in');
+
+      expect(accessToken).toBe('2YotnFZFEjr1zCsicMWpAA');
+      expect(state).toBe('xyz');
+      expect(tokenType).toBe('example');
+      expect(expiresIn).toBe('3600');
+    });
   });
 
   describe('createAuthorizeUrl', () => {

projects/angular-auth-oidc-client/src/lib/utils/url/url.service.ts

@@ -33,7 +33,7 @@ export class UrlService {
     }
 
     name = name.replace(/[\[]/, '\\[').replace(/[\]]/, '\\]');
-    const regex = new RegExp('[\\?&]' + name + '=([^&#]*)');
+    const regex = new RegExp('[\\?&#]' + name + '=([^&#]*)');
     const results = regex.exec(urlToCheck);
 
     return results === null ? '' : decodeURIComponent(results[1]);