Merge pull request #1078 from kmathy/fix/Uint8Array

damienbod · web-flow · commit 7f8701ca3bd4 · 2021-04-29T19:54:59.000+02:00
fix(randomService): fix misuse of Uint8Array
diff --git a/projects/angular-auth-oidc-client/src/lib/flows/random/random.service.ts b/projects/angular-auth-oidc-client/src/lib/flows/random/random.service.ts
@@ -17,7 +17,7 @@ export class RandomService {
     }
 
     const length = requiredLength - 6;
-    const arr = new Uint8Array((length || length) / 2);
+    const arr = new Uint8Array(Math.floor((length || length) / 2));
     if (this.getCrypto()) {
       this.getCrypto().getRandomValues(arr);
     }

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@ export class RandomService {`
`17`	`17`	`}`
`18`	`18`
`19`	`19`	`const length = requiredLength - 6;`
`20`		`- const arr = new Uint8Array((length \|\| length) / 2);`
	`20`	`+ const arr = new Uint8Array(Math.floor((length \|\| length) / 2));`
`21`	`21`	`if (this.getCrypto()) {`
`22`	`22`	`this.getCrypto().getRandomValues(arr);`
`23`	`23`	`}`