Skip to content

Commit a8b8229

Browse files
authored
Merge pull request Expensify#57580 from QichenZhu/fix/56156
Bump react-native-keyboard-controller to 1.16.7
2 parents 22e1e44 + c4a6cb9 commit a8b8229

File tree

6 files changed

+23
-7
lines changed

6 files changed

+23
-7
lines changed

ios/Podfile.lock

+2-2
Original file line numberDiff line numberDiff line change
@@ -1827,7 +1827,7 @@ PODS:
18271827
- ReactCommon/turbomodule/bridging
18281828
- ReactCommon/turbomodule/core
18291829
- Yoga
1830-
- react-native-keyboard-controller (1.15.2):
1830+
- react-native-keyboard-controller (1.16.7):
18311831
- DoubleConversion
18321832
- glog
18331833
- hermes-engine
@@ -3406,7 +3406,7 @@ SPEC CHECKSUMS:
34063406
react-native-geolocation: b9bd12beaf0ebca61a01514517ca8455bd26fa06
34073407
react-native-image-picker: ba5067f7d833b9081102c0a33dd0188eb21d92dc
34083408
react-native-key-command: aae312752fcdfaa2240be9a015fc41ce54087546
3409-
react-native-keyboard-controller: dbd7fb6a233505f937c9242d6d8bb5ebe659ec32
3409+
react-native-keyboard-controller: 2dd8ddb3c2acbd006404dc58ebc856c7704fea5a
34103410
react-native-launch-arguments: 5f41e0abf88a15e3c5309b8875d6fd5ac43df49d
34113411
react-native-netinfo: fb5112b1fa754975485884ae85a3fb6a684f49d5
34123412
react-native-pager-view: abc5ef92699233eb726442c7f452cac82f73d0cb

package-lock.json

+4-4
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@
165165
"react-native-image-picker": "^7.1.2",
166166
"react-native-image-size": "git+https://github.com/Expensify/react-native-image-size#cb392140db4953a283590d7cf93b4d0461baa2a9",
167167
"react-native-key-command": "^1.0.8",
168-
"react-native-keyboard-controller": "1.15.2",
168+
"react-native-keyboard-controller": "1.16.7",
169169
"react-native-launch-arguments": "^4.0.2",
170170
"react-native-localize": "^2.2.6",
171171
"react-native-modal": "^13.0.0",
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
// Selection position returned from react-native-keyboard-controller is platform-dependent, so set different paddings for Android and iOS.
2+
function getBottomSuggestionPadding(): number {
3+
return 30;
4+
}
5+
6+
export default getBottomSuggestionPadding;
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
import type {GetScrollPositionType} from './types';
2+
3+
// Use a stub function as react-native-keyboard-controller already accounts for the scroll position on Android.
4+
function getScrollPosition(): GetScrollPositionType {
5+
return {
6+
scrollValue: 0,
7+
};
8+
}
9+
10+
export default getScrollPosition;

0 commit comments

Comments
 (0)