Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Cloudflare Pages build option (again) #1279

Open
rmarscher opened this issue Mar 1, 2025 · 1 comment
Open

Add a Cloudflare Pages build option (again) #1279

rmarscher opened this issue Mar 1, 2025 · 1 comment

Comments

@rmarscher
Copy link
Contributor

We updated our --with-cloudflare build option from Cloudflare Workers to Cloudflare Pages and then back to Cloudflare Pages with Static Assets.

Related:

I found that while Cloudflare Pages' advanced mode function and Cloudflare Workers are almost the same, it seems that Cloudflare Pages' advanced mode function runs after Cloudflare's edge cache while a Cloudflare Worker always runs before the cache. cloudflare/cloudflare-docs#20445

For sites that want to do SWR, it can be better to leverage Cloudflare's cache rules instead of using Cloudflare's cache API from within a worker.

@dai-shi
Copy link
Owner

dai-shi commented Mar 2, 2025

If it's a long-term decision, we could separate two options: ---with-cloudflare-workers and --with-cloudflare-pages
Isn't the plan to integrate Workers and Pages in the future?

And, it depends on how much percentage of waku + cloudflare users need Pages.

Another option is to allow a user-defined deploy adapter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants