Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date/time input broken (no input events) since 3.5.0 #5476

Closed
dvic opened this issue Oct 25, 2019 · 5 comments · Fixed by #5498
Closed

Date/time input broken (no input events) since 3.5.0 #5476

dvic opened this issue Oct 25, 2019 · 5 comments · Fixed by #5498
Assignees
Labels
type: regression A bug that didn't appear until a specific Cy version release v3.5.0 🐛 Issue present since 3.5.0

Comments

@dvic
Copy link

dvic commented Oct 25, 2019

Current behavior:

Date inputs are not emitting input events since version 3.5.0.

Desired behavior:

When typing into a date input field, I expect the field to emit an input event (works in <= 3.4.1).

Steps to reproduce: (app code and test code)

https://github.com/cypress-io/cypress-test-tiny/pull/52/files

image

Versions

3.5.0

@jennifer-shehane
Copy link
Member

I have confirmed that the code example above passes in 3.4.1 and fails in 3.5.0.

@jennifer-shehane jennifer-shehane added the type: regression A bug that didn't appear until a specific Cy version release label Oct 28, 2019
@cypress-bot cypress-bot bot added the stage: needs investigating Someone from Cypress needs to look at this label Oct 28, 2019
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review and removed stage: needs investigating Someone from Cypress needs to look at this labels Oct 28, 2019
@kuceb kuceb changed the title Date input broken (no input events) since 3.5.0 Date/time input broken (no input events) since 3.5.0 Oct 28, 2019
@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Oct 30, 2019
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 30, 2019

The code for this is done in cypress-io/cypress#5498, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 5, 2019

Released in 3.6.0.

@dvic
Copy link
Author

dvic commented Nov 5, 2019

@bkucera the fix in 3.6.0 seems to fix most of our failing tests but there still seems to be a problem with programmatically resetting the input field back to the original value after calling clear(). Will investigate and let you know.

@jennifer-shehane
Copy link
Member

This issue will be closed to further comment as the exact issue here was resolved and tested.

If you're experiencing a bug similar to this in Cypress, please open a new issue with a fully reproducible example that we can run. There may be a specific edge case with the issue that we need more detail to fix.

@cypress-io cypress-io locked as resolved and limited conversation to collaborators Dec 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: regression A bug that didn't appear until a specific Cy version release v3.5.0 🐛 Issue present since 3.5.0
Projects
None yet
3 participants